-
Notifications
You must be signed in to change notification settings - Fork 20
Fix labelling and position of HCP grains in IPF #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This breaks ifp colour plotting so not a good approach. maybe just changing the labels is fine. |
This will have broken IPF colour calculation!
Have you checked the IPF colouring for cubic and hex crystals when you fixed? I fixed and checked IPF point plotting for both but didn't account for breaking colouring at all. |
I checked hex and did a quick patch cb858f4. I'll check cubic also and get back to you. |
Bring hcp_ipf_fix branch up to date with develop
From known correct values
@mikesmic I've added a test for |
Can't we just change the directions the colour components are calculated against and use the 'up' convention we already have? Test looks good. Could you add a few more cases, maybe with crystal directions other than <100> and then I'll try to make the colours work |
Sounds good. Added an additional ori and some directions. Something in file_readers is breaking tests on Python <=3.10 also. |
Add more non-001 orientations
I know what the issue is with the file readers, I'll fix later. |
I've updated the RGB directions so the extra IPF triangle convention isn't needed. The only thing I didn't check is changing the hex orthonormalisation convention from hkl to tsl. Not sure what happened with that before. |
I was thinking of adding a test in the EBSD class also to check for the correct result for ipf x,y,z colours and positions, using the test ebsd data? Would also need one for hcp and perhaps non-OI data as well? Would that do the job? |
HCP orientations are now plotted onto the IPF in the correct place. There is an option to choose between triangle facing down (like aztec) and triangle facing up (like mtex).