Skip to content

Fix labelling and position of HCP grains in IPF #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Conversation

rhysgt
Copy link
Contributor

@rhysgt rhysgt commented Dec 5, 2024

HCP orientations are now plotted onto the IPF in the correct place. There is an option to choose between triangle facing down (like aztec) and triangle facing up (like mtex).

@rhysgt rhysgt self-assigned this Dec 5, 2024
@rhysgt rhysgt marked this pull request as ready for review December 5, 2024 13:09
@rhysgt rhysgt requested a review from mikesmic as a code owner December 5, 2024 13:09
@rhysgt rhysgt marked this pull request as draft December 5, 2024 22:58
@rhysgt
Copy link
Contributor Author

rhysgt commented Dec 5, 2024

This breaks ifp colour plotting so not a good approach. maybe just changing the labels is fine.

rhysgt and others added 3 commits December 5, 2024 23:30
This will have broken IPF colour calculation!
Patch to fix the IPF colour issues for now
@rhysgt rhysgt mentioned this pull request Feb 3, 2025
@rhysgt rhysgt marked this pull request as ready for review February 4, 2025 10:38
@mikesmic
Copy link
Collaborator

mikesmic commented Feb 4, 2025

Have you checked the IPF colouring for cubic and hex crystals when you fixed? I fixed and checked IPF point plotting for both but didn't account for breaking colouring at all.

@rhysgt
Copy link
Contributor Author

rhysgt commented Feb 4, 2025

I checked hex and did a quick patch cb858f4. I'll check cubic also and get back to you.

rhysgt added 3 commits August 4, 2025 13:28
Bring hcp_ipf_fix branch up to date with develop
From known correct values
@rhysgt
Copy link
Contributor Author

rhysgt commented Aug 4, 2025

@mikesmic I've added a test for Quat.calc_ipf_colours based on values that I know are correct. Do you have any suggestions on how to improve? I have also added a patch to fix the cubic\hex ipf colours, but could do with improving the logic. Currently, I pass triangle='ipf_map', which uses the same beta_range as before.

@mikesmic
Copy link
Collaborator

mikesmic commented Aug 4, 2025

Can't we just change the directions the colour components are calculated against and use the 'up' convention we already have? Test looks good. Could you add a few more cases, maybe with crystal directions other than <100> and then I'll try to make the colours work

@rhysgt
Copy link
Contributor Author

rhysgt commented Aug 5, 2025

Sounds good. Added an additional ori and some directions. Something in file_readers is breaking tests on Python <=3.10 also.

Add more non-001 orientations
@mikesmic
Copy link
Collaborator

mikesmic commented Aug 5, 2025

I know what the issue is with the file readers, I'll fix later.

@mikesmic
Copy link
Collaborator

I've updated the RGB directions so the extra IPF triangle convention isn't needed. The only thing I didn't check is changing the hex orthonormalisation convention from hkl to tsl. Not sure what happened with that before.

@rhysgt
Copy link
Contributor Author

rhysgt commented Aug 14, 2025

I was thinking of adding a test in the EBSD class also to check for the correct result for ipf x,y,z colours and positions, using the test ebsd data? Would also need one for hcp and perhaps non-OI data as well? Would that do the job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants