-
Notifications
You must be signed in to change notification settings - Fork 14
148 exception fail fast #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the various functions.
…bose methods, and TCLAP SwitchArg. Added verbose field as optional argument to most python wrappers. Need to keep working on adding the proper reading of the verbose argument in the C++ commands + the linking with the python code.
…bose methods, and TCLAP SwitchArg. Added verbose field as optional argument to most python wrappers. Need to keep working on adding the proper reading of the verbose argument in the C++ commands + the linking with the python code. WIP: Add missing file to previous commit.
…bose methods, and TCLAP SwitchArg. Added verbose field as optional argument to most python wrappers. Need to keep working on adding the proper reading of the verbose argument in the C++ commands + the linking with the python code. WIP: Add missing file to previous commit. WIP: finished removing debug lines from TVSR.cxx
…ged and displayed after the whole run finished.
… by removing try-except.
…erbosity output in srr_assessment_stage
…participants in alphabetical order. Check that only allowed keys are given in participants params and check integrity of input in preprocess.py
Hello @t-sanchez! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-09-06 16:14:19 UTC |
…alysis-Laboratory/mialsuperresolutiontoolkit into 148_exception_fail_fast
…inputs as inputs, but rather as attributes of the modules.
…ack some attributes of MialsrtkTVSuperResolution to inputs.
… check_parameters_integrity and remove nipype import in srr_assessment_stage.
BUG: add EXEC_PATH BUG: add EXEC_PATH in postprocess.py
This was tested against several use cases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--verbose
attribute.usage.rst
This should fix Change handling of exceptions towards a faster failure of modules #148, Change the default level of verbosity #151, Implement a check of incompatible input parameters #172, Fix file not found issue #179.