Skip to content

148 exception fail fast #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Sep 7, 2022
Merged

148 exception fail fast #178

merged 37 commits into from
Sep 7, 2022

Conversation

t-sanchez
Copy link
Contributor

@t-sanchez t-sanchez commented Sep 6, 2022

…bose methods, and TCLAP SwitchArg. Added verbose field as optional argument to most python wrappers. Need to keep working on adding the proper reading of the verbose argument in the C++ commands + the linking with the python code.
…bose methods, and TCLAP SwitchArg. Added verbose field as optional argument to most python wrappers. Need to keep working on adding the proper reading of the verbose argument in the C++ commands + the linking with the python code.

WIP: Add missing file to previous commit.
…bose methods, and TCLAP SwitchArg. Added verbose field as optional argument to most python wrappers. Need to keep working on adding the proper reading of the verbose argument in the C++ commands + the linking with the python code.

WIP: Add missing file to previous commit.

WIP: finished removing debug lines from TVSR.cxx
…ged and displayed after the whole run finished.
…participants in alphabetical order. Check that only allowed keys are given in participants params and check integrity of input in preprocess.py
@pep8speaks
Copy link

pep8speaks commented Sep 6, 2022

Hello @t-sanchez! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 195:80: E501 line too long (84 > 79 characters)

Comment last updated at 2022-09-06 16:14:19 UTC

@t-sanchez
Copy link
Contributor Author

This was tested against several use cases:

  • multiparameter reconstruction:
docker run -t --rm -u $(id -u):$(id -g) -v $DATA_PATH:/bids_dir -v $OUT_PATH:/output_dir sebastientourbier/mialsuperresolutiontoolkit-bidsapp:v2.1.0-dev /bids_dir /output_dir participant --param_file /bids_dir/code/simu_run-50.json --participant_label simu005 --nipype_nb_of_cores 1  --openmp_nb_of_cores 3 --masks_derivatives_dir masks
  • Reconstruction with labelmaps:
docker run -t --rm -u $(id -u):$(id -g) -v $DATA_PATH:/bids_dir -v $OUT_PATH:/output_dir -v $ATLAS_PATH:/sta sebastientourbier/mialsuperresolutiontoolkit-bidsapp:v2.1.0-dev /bids_dir /output_dir participant --param_file /bids_dir/code/simu_run-30.json --participant_label 04 --nipype_nb_of_cores 1  --openmp_nb_of_cores 3 --masks_derivatives_dir masks --labels_derivatives_dir labels
  • Preprocessing only pipeline
docker run -t --rm -u $(id -u):$(id -g) -v $DATA_PATH:/bids_dir -v $OUT_PATH:/output_dir sebastientourbier/mialsuperresolutiontoolkit-bidsapp:v2.1.0-dev-verbose /bids_dir /output_dir participant --param_file /bids_dir/code/clinical_run_prepro.json --participant_label chuv012 chuv026 --run_type preprocessing --nipype_nb_of_cores 1  --openmp_nb_of_cores 3 > out_prepro.txt
  • Reconstruction with reorientation
docker run -t --rm -u $(id -u):$(id -g) -v $DATA_PATH:/bids_dir -v $OUT_PATH:/output_dir -v $ATLAS_PATH:/sta sebastientourbier/mialsuperresolutiontoolkit-bidsapp:v2.1.0-dev /bids_dir /output_dir participant --param_file /bids_dir/code/simu_run-21.json --participant_label simu005 --nipype_nb_of_cores 1  --openmp_nb_of_cores 3 --masks_derivatives_dir masks --labels_derivatives_dir labels > out_reorient.txt
  • A run that was known to generate some file not found errors:
docker run --rm -t -u $(id -u):$(id -g) -v $DATA_PATH:/bids_dir -v $OUT_PATH:/output_dir -v $ATLAS_PATH:/sta sebastientourbier/mialsuperresolutiontoolkit-bidsapp:v2.1.0-dev /bids_dir /output_dir participant --param_file /bids_dir/code/clinical_run-5.json --openmp_nb_of_cores 3 --nipype_nb_of_cores 1 --participant_label chuv012 chuv026 --masks_derivatives_dir masks > 210_old.out

@t-sanchez t-sanchez merged commit 3179361 into v2.1.0 Sep 7, 2022
@t-sanchez t-sanchez deleted the 148_exception_fail_fast branch September 7, 2022 06:10
@sebastientourbier sebastientourbier added this to the v2.0.4 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants