Skip to content

Use Rocky Linux 8 for building Python packages #4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 21, 2025

Conversation

oitel
Copy link
Contributor

@oitel oitel commented Jul 17, 2025

No description provided.

@oitel oitel added the skip-image-rebuild force to skip docker image rebuild label Jul 17, 2025
@oitel oitel changed the title WIP: Use Rocky Linux 8 for building Python packages Use Rocky Linux 8 for building Python packages Jul 17, 2025
@oitel oitel marked this pull request as ready for review July 17, 2025 13:16
Copy link
Contributor

@Grantim Grantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add readme to opencascade patches?

Comment on lines +128 to +129
- name: Install uv
uses: astral-sh/setup-uv@bd01e18f51369d5a26f1651c3cb451d3417e3bba # v6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb add comment what is it and why is it needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@@ -56,7 +56,7 @@ def patch_whl(out_dir,libs_dir):
elif SYSTEM == "Linux":
sys.path.append(libs_dir) # to find SO files
# see also: https://github.com/mayeut/pep600_compliance
manylinux_version = "2_31"
manylinux_version = "2_28"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about that, because we are calling it on ubutnu20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

Comment on lines 1 to 6
#!/usr/bin/env python3
import sysconfig

if __name__ == '__main__':
import sys
print(sysconfig.get_config_var(sys.argv[1]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To retrieve system paths for multiple Python instances.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment.

@oitel oitel merged commit 1ca4aa6 into master Jul 21, 2025
54 of 55 checks passed
@oitel oitel deleted the feature/pip_manylinux_rockylinux8 branch July 21, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants