Skip to content

Feed CMEW's model_id through to ESMValTool recipe #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Feed CMEW's model_id through to ESMValTool recipe #265

wants to merge 12 commits into from

Conversation

mo-johnmo
Copy link
Contributor

@mo-johnmo mo-johnmo commented Mar 31, 2025 •
edited
Loading

Closes #260.

PR creation checklist for the developer

  • Has <issue_number> above ☝️ been replaced with the issue number?
  • Has main been selected as the base branch?
  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the text of the PR title exactly match with the text (not including the issue number) of the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer(s)?
  • Have the same labels as on the issue (except for the good first issue label) been added to the PR?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the developer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the requirements in the wiki: Developer Guide (including copyrights)?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation (e.g. docstrings in Python modules) related to the change been updated appropriately?
  • Has the user documentation (i.e. everything in the doc directory) related to the change been updated appropriately, including the Quick Start section?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)

PR creation checklist for the reviewer

  • Has <issue_number> above ☝️ been replaced with the issue number?
  • Has main been selected as the base branch?
  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the text of the PR title exactly match with the text (not including the issue number) of the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer(s)?
  • Have the same labels as on the issue (except for the good first issue label) been added to the PR?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the reviewer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the requirements in the wiki: Developer Guide (including copyrights)?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation (e.g. docstrings in Python modules) related to the change been updated appropriately?
  • Has the user documentation (i.e. everything in the doc directory) related to the change been updated appropriately, including the Quick Start section?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)

mo-johnmo added 12 commits March 25, 2025 16:59
@mo-johnmo
#142: Two models in a run.
76eb059
@mo-johnmo
#142: restructure_dirs.sh variables quoted. Delete opt/rose-suite-mod…
58e9b10 
…el2.conf

and remove its MODELS_OPTION from other files.  Move configure_for rose-app.conf
to a bash script.
@mo-johnmo
#142: Edit app/configure_for/rose-app.conf .
ff58b2f
@mo-johnmo
#142: Correct configure_for task, updating datasets with test and ref…
22d102c 
…erence

variant labels.
@mo-johnmo
#142: Remove command line parameters from
ab955a2 
app/configure_for/update_recipe_file.py as they are no longer needed.  Revert
to using environment variables.
@mo-johnmo
#142: Amend the recipe details for test and reference models.
b04203b
@mo-johnmo
260: Merge changes from branch 142. Update flow.cylc for model_id* va…
0eba7b2 
…riables

at configure_for .
@mo-johnmo
#142: Remove the update() method thus reverting the structural change…
dbb8cb5 
… while

retaining the variant_label and variant_label_reference additions.
@mo-johnmo
#142: Changes from review of configure_standardise task components.
899baf1
@mo-johnmo
#142: configure_standardise.sh must have all arguments to cmew-proces…
0b608f1 
…s-env on

same line.
@mo-johnmo
#142: Corrected a missing char from argument name.
1b9ef33
@mo-johnmo
# 260: Merge branch '142_two_model_runs'.
442a2cc
@mo-johnmo mo-johnmo added the enhancement New feature or request label Mar 31, 2025
@mo-johnmo mo-johnmo added this to the v0.2.0 milestone Mar 31, 2025
@alistairsellar alistairsellar self-assigned this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alistairsellar alistairsellar

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Feed CMEW's model_id through to ESMValTool recipe
2 participants
@mo-johnmo @alistairsellar