Ingestion of synoptic observations #1579
Conversation
|
|
jfrost-mo
force-pushed
the
CSET_Obs_JME_310725
branch
from
c820209 to
f5cb2ec
Compare
There was a problem hiding this comment.
Sorry this took so long to review.
It looks like a good approach. I've got a few questions and suggestions that I've left as comments, both nothing that should be too arduous.
I've also reviewed https://github.com/MetOffice/CSET-workflow/pull/199 and aside from needing a path updated it is also good to go. I suggest it is merged at the same time as this one.
src/CSET/cset_workflow/includes/spatial_surface_model_obs_diference.cylc
Outdated
Show resolved
Hide resolved
src/CSET/cset_workflow/includes/spatial_surface_model_obs_diference.cylc
Show resolved
Hide resolved
There was a problem hiding this comment.
From a science perspective the only thing is adding a little bit more to the descriptions in the recipes following @jfrost-mo's comments. Also worth adding in a few tests.
|
Reviewing changes have been implemented. We should think about the general policy on testing observational code, since that may involve running code in the restricted repository. |
This branch follows #1456 in implementing the changes cleanly from a more recent version of CSET.