WIP Add search capability to CSET UI #1713
Draft
+17,898
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally included is a conversion to JSON Lines (In theory it should be more efficient, but in practice we still load the whole string first, so I may revert. At least it looks nicer in the index file.) Finally there are also some experiments with the UI for facets, ahead of getting feedback from the user interviews. The framework is there for facet-based searching, but the current implementation of search is very basic, only doing exact substring matching. Additional functionality should be added to the test function constructed in parse_query.
jfrost-mo
force-pushed
the
MSc_ui_improvements
branch
from
dcb8464 to
281677c
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally included is a conversion to JSON Lines (In theory it should be more efficient, but in practice we still load the whole string first, so I may revert. At least it looks nicer in the index file.)
Finally there are also some experiments with the UI for facets, ahead of getting feedback from the user interviews.
The framework is there for facet-based searching, but the current implementation of search is very basic, only doing exact substring matching. Additional functionality should be added to the test function constructed in parse_query.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.