Um owners git #111
Merged
Um owners git #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-siddall
requested changes
Sep 17, 2025
There was a problem hiding this comment.
Pretty much all of this looks good to be merged in, and well done for remembering to format using f-strings. I just have one very trivial issue with the control flow of an if elif block in suite_data.py as it looks like it won't do what you've intended it to do.
jennyhickson
added
the
crSet
Pierre-siddall
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
After figuring out the context I missed with @james-bruten-mo this is now approved.
cameronbateman-mo
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replicate the functionality from the old suite_report, producing a list of required Code and Config owner approvals for the UM. The below trac.log has been made with this branch, which contains some changes to trigger various code and config owners.
Checklist
Test Suite Results - um - test_um_code_owners/run3
Suite Information
Approvals
Code Owners
Config Owners
Task Information
❌ failed tasks - 20
✅ succeeded tasks - 344
⌛ waiting tasks - 1