Skip to content

Conversation

t00sa
Copy link
Contributor

@t00sa t00sa commented Jun 9, 2025

Description

Summary

Fix the svn pattern in UMDP3 checker to deal with repo name changes.

Changes

Minor change to the trunk branch pattern.

Dependency

None

Impact

None

Issues addressed

Coordinated merge

NA

Checklist

  • I have performed a self-review of my own changes

@t00sa t00sa requested a review from a team as a code owner June 9, 2025 08:26
@t00sa t00sa requested review from ericaneininger and cameronbateman-mo and removed request for a team June 9, 2025 08:26
The previous change failed because it only accounted for server name
changes and didn't address the move from svn:// to https:// URLs.
This adds an extra rule to address https branches.
@james-bruten-mo james-bruten-mo self-requested a review June 9, 2025 13:05
Copy link
Contributor

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested that these work on the current UM trunk and it does fix the issue caused by the mirror update

Copy link
Contributor

@ericaneininger ericaneininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me - adds an additional regex for the repo URL.

@ericaneininger ericaneininger merged commit 0e8e97c into main Jun 9, 2025
19 checks passed
@ericaneininger ericaneininger deleted the umdp3-url-fix branch June 9, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants