-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Contact Details
No response
Are there any linked Issues or Pull Requests?
Yes! PR #197
Brief description
A bit of outstanding technical debt from identified by @andrewcoughtrie as part of his review of the PR:
My thoughts are both that this shouldn't be kept in the mpi_context.cpp file it would probably be preferable to wrap/dummy the actual MPI calls and have the actually use in the single.cpp file. This would keep the MPI usage contained away from our usage in the writers.
Further details of the issue.
A big chunk of code in mpi_context.cpp
is currently ifdef
ed out when MPI isn't available. This should be replaced with some dummy functions to make it consistent with the approach used elsewhere in the code base.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request