Enable IAU to be used within the DA outer loop - first stage of developments#496
Open
Samantha Pullen (SamanthaPullen) wants to merge 5 commits into
Open
Conversation
Samantha Pullen (SamanthaPullen)
added a commit
to SamanthaPullen/lfric_apps
that referenced
this pull request
May 15, 2026
Contributor
Author
|
Hi Steven Sandbach (@ss421) - I think everything is ready now. Passing to you for SR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Steven Sandbach (@ss421)
Code Reviewer: Harry Shepherd (@harry-shepherd)
An outer loop capability is in development for the JADA 4D-VAR data assimilation (DA) cycle. This will require lfric_atm to be run iteratively across the 6-hour DA window from the JEDI environment, with its initial state updated by a set of increments at each iteration. The IAU is well placed to carry out these incremental updates, however it will need some small adaptations to satisfy the requirements of the outer loop updates. Note that this is a completely separate application of lfric_atm (repeated short runs within the DA cycle as part of the process to calculate analysis increments) to its use for a full NWP forecast (new long forecast from an analysis state which has been updated with analysis increments from the completed DA cycle).
This PR represents the first stage of IAU developments for outer loop capability and enables the following IAU behaviour with the activation of a new namelist option
iau_outerloop:initialise) as normal - it is anticipated that the main lfric_atm initialise routine will be run once at the start of the DA cycle, and then updates to modeldb fields made, as needed, at each iteration of the outer loop.iau_fieldsfield collection is not removed at the end ofinitialisefor an outer loop application since the field collection will be needed, and filled, at the end of each outer loop iteration.This change includes an upgrade macro, which has been tested on test branch: https://github.com/SamanthaPullen/lfric_apps/tree/test_iau_outerloop_stage1
Code Quality Checklist
Testing
This change was tested by temporarily adding iau_outerloop=.true. to the rose-stem lfric_atm da optional config (at 508715c).
The da task ran successfully, and skipped reading IAU increments from file and the IAU updating of the prognostic state, as anticipated: output here
The only failures were the da task kgo checks, as expected (since we have not applied IAU increments)
Rose stem testing has been performed for the development branch SamanthaPullen/lfric_apps@iau_outerloop_stage1 and the test branch, with upgrade macro applied SamanthaPullen/lfric_apps@test_iau_outerloop_stage1
A new rose-stem test has not been added at this stage, to test a config with iau_outerloop enabled, but this will be added once outer loop developments have advanced a little more, most likely in combination with jedi_lfric testing.
trac.log for dev branch
Test Suite Results - lfric_apps - iau_outerloop_stage1/run8
Suite Information
Task Information
✅ succeeded tasks - 1310
trac.log for test branch
Test Suite Results - lfric_apps - test_iau_outerloop_stage1/run1
Suite Information
Task Information
✅ succeeded tasks - 1511
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review