-
Notifications
You must be signed in to change notification settings - Fork 2
Give information when a time cannot be found in a file. #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice exception. Thanks.
One minor suggestion to consider, feel free to ignore. I'd prefer a YAML or fixed length indentation format (as opposed to a hanging indentation) to present the times available? What do you think? E.g.:
# Either:
Times available:
- 2024-09-25T18:00Z
- ...
# Or:
Times available: {
"2024-09-25T18:00Z",
"..."
}
Thanks Matt, I like the suggestion of YAML-formatted output. I've changed it to output your first suggestion. Cheers. |
Tests: http://fcm1/cylc-review/cycles/jcolclou/?suite=monio_datetime_err__2609 New error output (noticed I missed a space 3fe29c9):
|
Description
When a time cannot be found in a file, MONIO throws:
But this doesn't give any information on why the time is not in the file, so it takes some investigating. This PR changes this so that MONIO outputs what times it has available, and what was requested, so it can be compared.
Issue
Resolves #46