Skip to content

Commit d200c19

Browse files
update apps kgo instructions (#258)
1 parent dd13d6f commit d200c19

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

source/Reviewers/howtocommit.rst

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -466,15 +466,19 @@ Supporting data is stored in the filesystems of our machines and changes to use
466466
latter case, the update will need redoing by the reviewer before commit
467467
if there are merge conflicts in the checksum files.
468468

469-
1. Run the rose stem tasks that require a KGO update, plus any other testing required (see above) - if unsure run the `all` group.
469+
1. Fix any merge conflicts in the checksums - it shouldn't matter which merge option is selected as you will be overwriting these checksum files again in the following steps.
470+
471+
2. Run the rose stem tasks that require a KGO update, plus any other testing required (see above) - if unsure run the `all` group.
470472

471473
.. code-block:: RST
472474
473475
export CYLC_VERSION=8
474476
rose stem --group=all
475477
cylc play <suite name>
476478
477-
2. Run the checksum update script stored in `<working copy>/rose-stem/bin`.
479+
3. Ensure the failing KGO's match those on the branch.
480+
481+
4. Run the checksum update script stored in `<working copy>/rose-stem/bin`.
478482

479483
.. code-block::
480484
@@ -486,11 +490,11 @@ Supporting data is stored in the filesystems of our machines and changes to use
486490

487491
.. note::
488492
The numbered run directory must be included in the suite name, eg. `name-of-suite/run1`.
489-
490493

491-
3. Verify the checksums updated properly by retriggering the failed checksums. First retrigger
494+
495+
5. Verify the checksums updated properly by retriggering the failed checksums. First retrigger
492496
``export-source``, and then when complete ``export-source_xc40`` if new checksums are present
493-
there (there is no need to retigger spice). You may need to change the maximum window extent
497+
there (there is no need to retigger spice). You may need to change the maximum window extent
494498
of the gui in order to see the succeeded tasks. Now you can retrigger the failed checksums -
495499
these should now pass if the kgo was updated in the working copy correctly.
496500

0 commit comments

Comments
 (0)