update kgo instructions #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bruten-mo
requested review from
a team and
jennyhickson
and removed request for
a team
There was a problem hiding this comment.
I wonder if it'd be easier to just include this in the command as "<suite name/runX>" rather than add an extra note? Happy to go with the note if you'd rather though.
Also I think these KGO instructions are somewhere else too (maybe How to Commit?) so worth doing the same thing in both places
|
Added to the 2nd place. I maybe overthink this, but I always feel that because the runN symlink is there, it's a bit unclear to just have runN or runX in an example. I don't want the instructions to give the impression you have to use that symlink? |
jennyhickson
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that the
runNdirectory is needed for an lfric apps kgo update.