Skip to content

update kgo instructions #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2024
Merged

update kgo instructions #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ed3c33
update kgo instructions
james-bruten-mo Aug 14, 2024
b85fb50
add note to howtocommit page
james-bruten-mo Aug 14, 2024
c5ed058
add runX
james-bruten-mo Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion source/Reviewers/howtocommit.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,12 +477,15 @@ for all affected tests before you commit to the trunk.

.. code-block::

python3 ./rose-stem/bin/update_branch_kgos.py -s <suite name> -w <path to working copy>
python3 ./rose-stem/bin/update_branch_kgos.py -s <suite name/runX> -w <path to working copy>

.. note::
This script requires at least python 3.9. This can be achieved on
Met Office machines by running ``module load scitools``

.. note::
The numbered run directory must be included in the suite name, eg. `name-of-suite/run1`.


.. tab-item:: LFRic Core

Expand Down
5 changes: 4 additions & 1 deletion source/WorkingPractices/kgo.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,15 @@ such changes onto the trunk. When preparing your change for review:

.. code-block::

python3 ./rose-stem/bin/update_branch_kgos.py -s <suite name> -w <path to working copy>
python3 ./rose-stem/bin/update_branch_kgos.py -s <suite name/runX> -w <path to working copy>

.. note::
This script requires at least python 3.9. This can be achieved on
Met Office machines by running ``module load scitools``

.. note::
The numbered run directory must be included in the suite name, eg. `name-of-suite/run1`.

4. The changes in answers should be science reviewed by someone familiar with
the failing tests - if unsure then start with the Code Owner for the affected
application.
Expand Down