Skip to content

update apps groups and fix typo #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024
Merged

update apps groups and fix typo #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/Reviewers/howtocommit.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,8 +565,8 @@ As reviewer, you should work with the developer, prior to moving to the commit s
#. Run relevant tests on XCS.
#. Wait for the daily `cron` job to run to synchronise data between `XCS` `XCE/F` & `SPICE`
#. Ensure that you are in charge of the in charge of the trunk for the repositories involved.
# Update your working copy if other commits have happened.
#. Rerun relevant tests on `XCE/F` and `SPICE`
#. Update your working copy if other commits have happened.
#. Rerun relevant tests on `XCE/F` and `SPICE`

If the requirement is to update existing files, then further care is required.

Expand All @@ -581,7 +581,7 @@ If the requirement is to update existing files, then further care is required.

- Waiting for the daily `cron` job to run can introduce a misalignment or race condition for scheduled testing.

#. Rerun relevant tests on `XCE/F` and `SPICE`
#. Rerun relevant tests on `XCE/F` and `SPICE`

- revert changes immediately if there are any issues, and consult with the developer.

Expand Down
7 changes: 1 addition & 6 deletions source/WorkingPractices/TestSuites/lfric_apps.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,8 @@ and that you can specify more than one at once, e.g. ``--group=developer,gungho_
| | to pass before commit. It is a useful checkpoint during |
| | development. |
+--------------------+----------------------------------------------------------+
| nightly | More thorough testing group. This includes everything in |
| | developer plus some longer and more complex tests. It is |
| | run automatically every night and monitored by the SSD |
| | team. |
+--------------------+----------------------------------------------------------+
| all | The complete test suite, including all longer runs and |
| | less commonly used utilites. This is run automatically |
| | less commonly used configs. This is run automatically |
| | every week and monitored by the SSD team. All |
| | :ref:`KGO <kgo>` changing tickets need to run this group.|
+--------------------+----------------------------------------------------------+
Expand Down