refactor: subscription service test util

Author: tuna1207

packages/subscription-controller/src/SubscriptionController.test.ts

@@ -140,12 +140,7 @@ function createMockSubscriptionService() {
 /**
  * Helper function to create controller with options.
  */
-type WithControllerCallback<ReturnValue> = ({
-  controller,
-  initialState,
-  messenger,
-  mockService,
-}: {
+type WithControllerCallback<ReturnValue> = (params: {
   controller: SubscriptionController;
   initialState: SubscriptionControllerState;
   messenger: SubscriptionControllerMessenger;

packages/subscription-controller/src/SubscriptionController.ts

@@ -11,18 +11,10 @@ import {
   controllerName,
   SubscriptionControllerErrorMessage,
 } from './constants';
-import type {
-  ProductType,
-  ISubscriptionService,
-  Subscription,
-  PendingPaymentTransaction,
-} from './types';
+import type { ProductType, ISubscriptionService, Subscription } from './types';
 
 export type SubscriptionControllerState = {
   subscriptions: Subscription[];
-  pendingPaymentTransactions?: {
-    [transactionId: string]: PendingPaymentTransaction;
-  };
 };
 
 // Messenger Actions
@@ -106,10 +98,6 @@ const subscriptionControllerMetadata: StateMetadata<SubscriptionControllerState>
       persist: true,
       anonymous: false,
     },
-    pendingPaymentTransactions: {
-      persist: true,
-      anonymous: false,
-    },
   };
 
 export class SubscriptionController extends BaseController<