fix: adjust network names (#4865)

## Explanation

The current state of the network nickname mappings does not fully align
with the naming conventions used by third-party providers, leading to
potential inconsistencies and confusion. Specifically, the names
"Mainnet" and "Linea Mainnet" do not match the standard conventions of
"Ethereum Mainnet" and "Linea." Updating these nicknames helps ensure
clarity and consistency across platforms.

The proposed changes standardize the network names by updating `Mainnet`
to `Ethereum Mainnet` and `Linea Mainnet` to `Linea`. This provides
better alignment with widely accepted naming conventions, making it
easier for consumers to understand and trust the network names
displayed.

## References

This change aligns the network names with conventions used by
third-party providers for Ethereum mainnet and Linea mainnet.

- Related to #67890

## Changelog

### `@metamask/controller-utils`

- **CHANGED**: Updated network nickname for `Mainnet` to `Ethereum
Mainnet` to standardize with third-party naming.
- **CHANGED**: Updated network nickname for `Linea Mainnet` to `Linea`
for consistency.

### `@metamask/network-controller`

- **CHANGED**: Updated network nickname for `Mainnet` to `Ethereum
Mainnet` to pass the unit tests.

## Checklist

- [x] I've updated the test suite for new or updated code as
appropriate.
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate.
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate.
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes.

Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>

Author: salimtb

packages/controller-utils/src/types.ts

@@ -108,12 +108,12 @@ export type BlockExplorerUrl =
   (typeof BlockExplorerUrl)[keyof typeof BlockExplorerUrl];
 
 export const NetworkNickname = {
-  [BuiltInNetworkName.Mainnet]: 'Mainnet',
+  [BuiltInNetworkName.Mainnet]: 'Ethereum Mainnet',
   [BuiltInNetworkName.Goerli]: 'Goerli',
   [BuiltInNetworkName.Sepolia]: 'Sepolia',
   [BuiltInNetworkName.LineaGoerli]: 'Linea Goerli',
   [BuiltInNetworkName.LineaSepolia]: 'Linea Sepolia',
-  [BuiltInNetworkName.LineaMainnet]: 'Linea Mainnet',
+  [BuiltInNetworkName.LineaMainnet]: 'Linea',
 } as const satisfies Record<InfuraNetworkType, string>;
 export type NetworkNickname =
   (typeof NetworkNickname)[keyof typeof NetworkNickname];

packages/network-controller/tests/NetworkController.test.ts

@@ -358,7 +358,7 @@ describe('NetworkController', () => {
                 "blockExplorerUrls": Array [],
                 "chainId": "0x1",
                 "defaultRpcEndpointIndex": 0,
-                "name": "Mainnet",
+                "name": "Ethereum Mainnet",
                 "nativeCurrency": "ETH",
                 "rpcEndpoints": Array [
                   Object {
@@ -428,7 +428,7 @@ describe('NetworkController', () => {
                 "blockExplorerUrls": Array [],
                 "chainId": "0xe708",
                 "defaultRpcEndpointIndex": 0,
-                "name": "Linea Mainnet",
+                "name": "Linea",
                 "nativeCurrency": "ETH",
                 "rpcEndpoints": Array [
                   Object {
@@ -3647,7 +3647,7 @@ describe('NetworkController', () => {
               }),
             ).toThrow(
               new Error(
-                "Could not add network with chain ID 0x1337 and Infura RPC endpoint for 'Mainnet' which represents 0x1, as the two conflict",
+                "Could not add network with chain ID 0x1337 and Infura RPC endpoint for 'Ethereum Mainnet' which represents 0x1, as the two conflict",
               ),
             );
           },
@@ -6531,7 +6531,7 @@ describe('NetworkController', () => {
                 ],
               }),
             ).rejects.toThrow(
-              "Could not update network to point to same RPC endpoint as existing network for chain 0x1 ('Mainnet')",
+              "Could not update network to point to same RPC endpoint as existing network for chain 0x1 ('Ethereum Mainnet')",
             );
           },
         );