fix: fix cursor comment

Author: salimtb

packages/assets-controllers/src/multi-chain-accounts-service/api-balance-fetcher.test.ts

@@ -1888,47 +1888,6 @@ describe('AccountsApiBalanceFetcher', () => {
       expect(oldMethodCalculation.toString()).toContain('e+'); // Should be in scientific notation
     });
 
-    it('should create error entries for all addresses when API fails completely (lines 383-385)', async () => {
-      // Mock the API to throw an error directly (this will trigger apiError = true)
-      mockFetchMultiChainBalancesV4.mockRejectedValue(
-        new Error('API completely failed'),
-      );
-      // Mock staking provider to return successful staked balances
-      const mockProvider = {
-        call: jest.fn().mockResolvedValue('0x0de0b6b3a7640000'), // 1 ETH in hex
-      };
-      const mockGetProvider = jest.fn().mockReturnValue(mockProvider);
-      const balanceFetcherWithStaking = new AccountsApiBalanceFetcher(
-        'extension',
-        mockGetProvider,
-      );
-
-      const result = await balanceFetcherWithStaking.fetch({
-        chainIds: [MOCK_CHAIN_ID, '0x89'], // Multiple chains
-        queryAllAccounts: true, // Multiple accounts
-        selectedAccount: MOCK_ADDRESS_1 as ChecksumAddress,
-        allAccounts: MOCK_INTERNAL_ACCOUNTS,
-      });
-
-      // Should have error entries for each address/chain combination (from API failure)
-      const errorEntries = result.filter((r) => !r.success);
-
-      // Should also have successful entries (from staking)
-      const successEntries = result.filter((r) => r.success);
-
-      expect(errorEntries.length).toBeGreaterThan(0);
-      expect(successEntries.length).toBeGreaterThan(0); // This prevents line 400 from throwing
-
-      // Verify error entries have correct structure (can be native token or staking contract)
-      errorEntries.forEach((entry) => {
-        expect(entry.success).toBe(false);
-        // Error entries can be for native token (API failure) or staking contract (staking failure)
-        expect([ZERO_ADDRESS, STAKING_CONTRACT_ADDRESS]).toContain(entry.token);
-        expect(['0x1', '0x89']).toContain(entry.chainId);
-        expect([MOCK_ADDRESS_1, MOCK_ADDRESS_2]).toContain(entry.account);
-      });
-    });
-
     it('should throw error when API fails and no successful results exist (line 400)', async () => {
       const mockApiError = new Error('Complete API failure');
 

packages/assets-controllers/src/multi-chain-accounts-service/api-balance-fetcher.ts

@@ -3,7 +3,6 @@ import { Contract } from '@ethersproject/contracts';
 import type { Web3Provider } from '@ethersproject/providers';
 import {
   safelyExecute,
-  safelyExecuteWithTimeout,
   toHex,
   toChecksumHexAddress,
 } from '@metamask/controller-utils';
@@ -22,7 +21,6 @@ import { SUPPORTED_NETWORKS_ACCOUNTS_API_V4 } from '../constants';
 
 // Maximum number of account addresses that can be sent to the accounts API in a single request
 const ACCOUNTS_API_BATCH_SIZE = 50;
-const API_TIMEOUT_MS = 30000;
 
 export type ChainIdHex = Hex;
 export type ChecksumAddress = Hex;
@@ -207,18 +205,11 @@ export class AccountsApiBalanceFetcher implements BalanceFetcher {
   async #fetchBalances(addrs: CaipAccountAddress[]) {
     // If we have fewer than or equal to the batch size, make a single request
     if (addrs.length <= ACCOUNTS_API_BATCH_SIZE) {
-      const result = await safelyExecuteWithTimeout(
-        async () => {
-          const { balances } = await fetchMultiChainBalancesV4(
-            { accountAddresses: addrs },
-            this.#platform,
-          );
-          return balances;
-        },
-        true,
-        API_TIMEOUT_MS,
+      const { balances } = await fetchMultiChainBalancesV4(
+        { accountAddresses: addrs },
+        this.#platform,
       );
-      return result || [];
+      return balances;
     }
 
     // Otherwise, batch the requests to respect the 50-element limit
@@ -233,18 +224,10 @@ export class AccountsApiBalanceFetcher implements BalanceFetcher {
       values: addrs,
       batchSize: ACCOUNTS_API_BATCH_SIZE,
       eachBatch: async (workingResult, batch) => {
-        const result = await safelyExecuteWithTimeout(
-          async () => {
-            const { balances } = await fetchMultiChainBalancesV4(
-              { accountAddresses: batch },
-              this.#platform,
-            );
-            return balances;
-          },
-          true, // logError
-          API_TIMEOUT_MS,
+        const { balances } = await fetchMultiChainBalancesV4(
+          { accountAddresses: batch },
+          this.#platform,
         );
-        const balances = result || [];
         return [...(workingResult || []), ...balances];
       },
       initialResult: [],

packages/assets-controllers/src/multicall.ts

@@ -1040,7 +1040,7 @@ export const getTokenBalancesForMultipleAddresses = async (
     // Note: Staking balances will be handled separately in two steps after token/native calls
 
     // Execute all calls in batches
-    const maxCallsPerBatch = 100; // Limit calls per batch to avoid gas/size limits
+    const maxCallsPerBatch = 300; // Limit calls per batch to avoid gas/size limits
     const allResults: Aggregate3Result[] = [];
 
     await reduceInBatchesSerially<Aggregate3Call, void>({