feat(backend-platform): clean code

Author: Kriys94

packages/backend-platform/src/AccountActivityService.test.ts

@@ -78,12 +78,14 @@ describe('AccountActivityService', () => {
     // Mock messenger
     mockMessenger = {
       registerActionHandler: jest.fn(),
+      registerMethodActionHandlers: jest.fn(),
       unregisterActionHandler: jest.fn(),
       registerInitialEventPayload: jest.fn(),
       publish: jest.fn(),
       call: jest.fn(),
       subscribe: jest.fn(),
       unsubscribe: jest.fn(),
+      clearEventSubscriptions: jest.fn(),
     } as any;
 
     // Mock selected account

packages/backend-platform/src/AccountActivityService.ts

@@ -555,8 +555,6 @@ export class AccountActivityService {
           }
         }
       });
-
-      console.log('AccountActivityService: System notification handlers set up successfully');
     } catch (error) {
       console.error('Failed to set up system notification handlers:', error);
     }

packages/backend-platform/src/WebSocketService.test.ts

@@ -224,6 +224,7 @@ const setupWebSocketService = ({
   // Create mock messenger with all required methods
   const mockMessenger = {
     registerActionHandler: jest.fn(),
+    registerMethodActionHandlers: jest.fn(),
     registerInitialEventPayload: jest.fn(),
     publish: jest.fn(),
     call: jest.fn(),
@@ -232,7 +233,7 @@ const setupWebSocketService = ({
   } as any as jest.Mocked<WebSocketServiceMessenger>;
 
   // Default test options (shorter timeouts for faster tests)
-  const defaultOptions: WebSocketServiceOptions = {
+  const defaultOptions = {
     url: TEST_CONSTANTS.WS_URL,
     timeout: TEST_CONSTANTS.TIMEOUT_MS,
     reconnectDelay: TEST_CONSTANTS.RECONNECT_DELAY,
@@ -368,14 +369,28 @@ describe('WebSocketService', () => {
         mockWebSocketOptions: { autoConnect: false }, // This prevents any connection
       });
 
-      // Wait for the automatic init() from constructor to complete and fail
+      // Service should start in disconnected state since we removed auto-init
+      expect(service.getConnectionInfo().state).toBe(WebSocketState.DISCONNECTED);
+      
+      // Use expect.assertions to ensure error handling is tested
+      expect.assertions(4);
+      
+      // Start connection and then advance timers to trigger timeout
+      const connectPromise = service.connect();
+      
+      // Handle the promise rejection properly
+      connectPromise.catch(() => {
+        // Expected rejection - do nothing to avoid unhandled promise warning
+      });
+      
       await completeAsyncOperations(TEST_CONSTANTS.TIMEOUT_MS + 50);
 
-      // Verify we're in error state from the failed init()
+      // Now check that the connection failed as expected
+      await expect(connectPromise).rejects.toThrow(`Failed to connect to WebSocket: Connection timeout after ${TEST_CONSTANTS.TIMEOUT_MS}ms`);
+      
+      // Verify we're in error state from the failed connection attempt
       expect(service.getConnectionInfo().state).toBe(WebSocketState.ERROR);
 
-      // The timeout behavior is already tested by the constructor's init() call
-      // We can verify that the error was due to timeout by checking the last error
       const info = service.getConnectionInfo();
       expect(info.lastError).toContain(`Connection timeout after ${TEST_CONSTANTS.TIMEOUT_MS}ms`);
 
@@ -467,12 +482,12 @@ describe('WebSocketService', () => {
     }, 10000);
 
     it('should throw error when not connected', async () => {
-      const { service, completeAsyncOperations, cleanup } = setupWebSocketService({
+      const { service, cleanup } = setupWebSocketService({
         mockWebSocketOptions: { autoConnect: false },
       });
 
-      // Wait for automatic init() to fail and transition to error state
-      await completeAsyncOperations(150);
+      // Service starts in disconnected state since we removed auto-init
+      expect(service.getConnectionInfo().state).toBe(WebSocketState.DISCONNECTED);
 
       const mockCallback = jest.fn();
 
@@ -481,7 +496,7 @@ describe('WebSocketService', () => {
           channels: ['test-channel'],
           callback: mockCallback,
         })
-      ).rejects.toThrow('Cannot create subscription(s) test-channel: WebSocket is error');
+      ).rejects.toThrow('Cannot create subscription(s) test-channel: WebSocket is disconnected');
 
       cleanup();
     });
@@ -803,8 +818,8 @@ describe('WebSocketService', () => {
         },
       } satisfies ClientRequestMessage;
 
-      // Should throw when not connected (service starts in connecting state)
-      await expect(service.sendMessage(testMessage)).rejects.toThrow('Cannot send message: WebSocket is connecting');
+      // Should throw when not connected (service starts in disconnected state)
+      await expect(service.sendMessage(testMessage)).rejects.toThrow('Cannot send message: WebSocket is disconnected');
 
       cleanup();
     });
@@ -998,8 +1013,24 @@ describe('WebSocketService', () => {
         mockWebSocketOptions: { autoConnect: false },
       });
 
-      // Wait for automatic init() to fail
+      // Service should start in disconnected state
+      expect(service.getConnectionInfo().state).toBe(WebSocketState.DISCONNECTED);
+
+      // Use expect.assertions to ensure error handling is tested
+      expect.assertions(5);
+
+      // Start connection and then advance timers to trigger timeout
+      const connectPromise = service.connect();
+      
+      // Handle the promise rejection properly
+      connectPromise.catch(() => {
+        // Expected rejection - do nothing to avoid unhandled promise warning
+      });
+      
       await completeAsyncOperations(TEST_CONSTANTS.TIMEOUT_MS + 50);
+      
+      // Wait for connection to fail
+      await expect(connectPromise).rejects.toThrow(`Failed to connect to WebSocket: Connection timeout after ${TEST_CONSTANTS.TIMEOUT_MS}ms`);
 
       const info = service.getConnectionInfo();
       expect(info.state).toBe(WebSocketState.ERROR);

packages/backend-platform/src/WebsocketService-method-action-types.ts

@@ -5,16 +5,6 @@
 
 import type { WebSocketService } from './WebsocketService';
 
-/**
- * Initializes and connects the WebSocket service
- *
- * @returns Promise that resolves when initialization is complete
- */
-export type WebSocketServiceInitAction = {
-  type: `WebSocketService:init`;
-  handler: WebSocketService['init'];
-};
-
 /**
  * Establishes WebSocket connection
  *
@@ -144,7 +134,6 @@ export type WebSocketServiceGetChannelCallbacksAction = {
  * Union of all WebSocketService action types.
  */
 export type WebSocketServiceMethodActions =
-  | WebSocketServiceInitAction
   | WebSocketServiceConnectAction
   | WebSocketServiceDisconnectAction
   | WebSocketServiceSendMessageAction

packages/backend-platform/src/WebsocketService.ts

@@ -5,7 +5,6 @@ import type { WebSocketServiceMethodActions } from './WebsocketService-method-ac
 const SERVICE_NAME = 'BackendWebSocketService' as const;
 
 const MESSENGER_EXPOSED_METHODS = [
-  'init',
   'connect',
   'disconnect', 
   'sendMessage',
@@ -284,27 +283,6 @@ export class WebSocketService {
       this,
       MESSENGER_EXPOSED_METHODS,
     );
-
-    this.init().catch((error) => {
-      console.error('WebSocket service initialization failed:', error);
-    });
-  }
-
-  /**
-   * Initializes and connects the WebSocket service
-   *
-   * @returns Promise that resolves when initialization is complete
-   */
-  async init(): Promise<void> {
-    try {
-      await this.connect();
-    } catch (error) {
-      const errorMessage = this.#getErrorMessage(error);
-
-      throw new Error(
-        `WebSocket service initialization failed: ${errorMessage}`,
-      );
-    }
   }
 
   /**
@@ -417,7 +395,7 @@ export class WebSocketService {
       throw new Error(`Cannot send request: WebSocket is ${this.#state}`);
     }
 
-    const requestId = this.#generateMessageId();
+    const requestId = uuidV4();
     const requestMessage: ClientRequestMessage = {
       event: message.event,
       data: {
@@ -547,8 +525,6 @@ export class WebSocketService {
 
     this.#channelCallbacks.set(options.channelName, channelCallback);
 
-    console.log(`Added channel callback for '${options.channelName}'`);
-    
     return options.channelName;
   }
 
@@ -583,9 +559,6 @@ export class WebSocketService {
     this.#clearTimers();
     this.#clearSubscriptions();
 
-    // Clear channel callbacks
-    this.#channelCallbacks.clear();
-
     // Clear any pending connection promise
     this.#connectionPromise = null;
 
@@ -1156,15 +1129,6 @@ export class WebSocketService {
     }
   }
 
-  /**
-   * Generates a unique message ID using UUID v4
-   *
-   * @returns Unique message identifier (UUID v4)
-   */
-  #generateMessageId(): string {
-    return uuidV4();
-  }
-
   /**
    * Gets human-readable close reason from RFC 6455 close code
    *