Skip to content

Conversation

gambinish
Copy link
Contributor

Explanation

Adds tokenNetworkFilter setting. Required for: MetaMask/metamask-mobile#11808

References

MetaMask/metamask-mobile#11808

Changelog

Adds tokenNetworkFilter with a default value of {} type Record<string, boolean>

@metamask/preferences-controller

  • : Updates controller with tokenNetworkFilter object, along with setters and types.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@gambinish gambinish requested a review from a team as a code owner October 30, 2024 17:11
@gambinish gambinish added the team-wallet-framework Deprecated: Please use `team-core-platform` instead. label Oct 30, 2024
@gambinish gambinish requested a review from salimtb October 30, 2024 17:13
*/
tokenSortConfig: TokenSortConfig;
/**
* Controls which order tokens are sorted in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this jsdoc doesn't seem to be correct and a copy of the one above it ?

@cryptodev-2s
Copy link
Contributor

@gambinish, could you please add some unit tests? You can use as an example how the other preferences are tested for reference.

@desi desi added team-wallet-framework Deprecated: Please use `team-core-platform` instead. and removed team-wallet-framework Deprecated: Please use `team-core-platform` instead. labels Nov 5, 2024
@gambinish gambinish closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-wallet-framework Deprecated: Please use `team-core-platform` instead.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants