Skip to content

Conversation

bergarces
Copy link
Contributor

@bergarces bergarces commented Aug 22, 2025

Explanation

  • Bumps @metamask/assets-controllers to 74.1.0.
  • Bumps devDependency to the same version for bridge-controller and updates changelog.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@bergarces bergarces requested review from a team as code owners August 22, 2025 14:09

## [Unreleased]

## [74.1.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a minor release? Is there any new functionality being added?

Copy link
Contributor Author

@bergarces bergarces Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new field is being added on top of the bug fixes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see mention of a new field in the changelog, was that added in #6358?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Uses the correct internal account type for the asset" — What does this mean? Are there any more details that could be provided here? Specifically, what part of the API is being changed and how?

Copy link
Contributor Author

@bergarces bergarces Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each asset type will now return the values used by InternalAccount type field.

Which one could argue is a breaking change, but we are seeing it as a bug fix, given that the selectors and the type were added in 74.0.0 and we have realised we need the internal account types for BTC different account types to be correctly identified.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Should this be in "Fixed" instead?

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@bergarces
Copy link
Contributor Author

I don't want to block any releases and I won't be back until Tuesday, so I'm going to close this and delete the branch until I can redo the release with all the comments addressed.

@bergarces bergarces closed this Aug 22, 2025
@bergarces bergarces deleted the release/510.0.0 branch August 22, 2025 16:27
@mcmire
Copy link
Contributor

mcmire commented Aug 22, 2025

@bergarces Sounds good. Ping me on Tuesday when you make the new release and I'll make sure to hop on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants