chore(network-controller): Speed up network client tests #6377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding |
There are a large amount of tests that exist for the network client that NetworkController creates and exposes. This is because the network client assembles a JsonRpcEngine middleware stack, one for Infura RPC endpoints and one for custom RPC endpoints, and the resulting behavior must be exercised somehow. Furthermore, we support not only RPC methods that are in the official Ethereum spec but also ones that fall outside of the spec, and we must exercise all of those methods too. Unfortunately, running all of these tests takes a long time in comparison to others, around 4+ minutes. This is rather painful when working with `network-controller` as the feedback loop is quite long. We can reduce this number by splitting up the suite of network client tests into multiple files. This means that Jest is able to now run them in parallel.
mcmire
force-pushed
the
speed-up-network-client-tests
branch
from
4c4ccc3 to
6014c69
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mcmire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
There are a large amount of tests that exist for the network client in
network-controller. This is because the network client assembles a JsonRpcEngine middleware stack, one for Infura RPC endpoints and one for custom RPC endpoints, and we must verify the resulting behavior across not only official Ethereum RPC methods but also MetaMask-specific RPC methods.Unfortunately, running all of these tests takes a long time in comparison to others, around 3.25 minutes. This is rather painful when working with
network-controller, as the feedback loop is quite long. We can reduce this number by splitting up the suite of network client tests into multiple files. This means that Jest is able to now run them in parallel. As a result, they now run in about 1.5 minutes, a 2x speedup.References
Checklist