fix(accounts-controller): workaround compiler error for recursive type #6432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Narrowing the
AccountControllerState
internally to avoid facing this issue:Json
causes a recursive error in conjunction withDraft
/WritableDraft
types from Immer utils#168This has no impact on the controller behavior or interface, it's purely related to the type-system and compiler errors.
I had errors when I was running the test locally with the compiler, but the CI ran fine. Now, it runs fine on both environment with no error/warning.
References
N/A
Checklist