Skip to content

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Sep 2, 2025

Explanation

Narrowing the AccountControllerState internally to avoid facing this issue:

This has no impact on the controller behavior or interface, it's purely related to the type-system and compiler errors.

I had errors when I was running the test locally with the compiler, but the CI ran fine. Now, it runs fine on both environment with no error/warning.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly ccharly force-pushed the fix/accounts-controller-relax-compiler-error-for-recursive-type branch from cc3acf7 to 16d6869 Compare September 2, 2025 16:48
@ccharly ccharly force-pushed the fix/accounts-controller-relax-compiler-error-for-recursive-type branch from 16d6869 to c145796 Compare September 2, 2025 16:49
@ccharly ccharly changed the title fix(accounts-controller): try to workaround compiler error for recursive type fix(accounts-controller): workaround compiler error for recursive type Sep 2, 2025
@ccharly
Copy link
Contributor Author

ccharly commented Sep 2, 2025

I used the "no-changelog" label since all those changes are only internal and has 0 impact on the public interface of the controller (nor its behavior).

@ccharly ccharly marked this pull request as ready for review September 2, 2025 16:55
@ccharly ccharly requested a review from a team as a code owner September 2, 2025 16:55
cursor[bot]

This comment was marked as outdated.

@ccharly ccharly enabled auto-merge (squash) September 2, 2025 17:01
Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Happy to finally have this out of our view 😄 Thanks a ton!

@ccharly ccharly merged commit 6cac875 into main Sep 2, 2025
235 checks passed
@ccharly ccharly deleted the fix/accounts-controller-relax-compiler-error-for-recursive-type branch September 2, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants