-
-
Notifications
You must be signed in to change notification settings - Fork 249
feat: Shared currency and token formatters #6577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Eventually it may be a good idea to move these over to the That said for now this seems good. |
@mcmire Discussed this with Mark, I considered |
@n3ps I see. Sounds good! |
Explanation
This is a port of the new
Intl.NumberFormat
currency formatters from metamask-extension. Moving it a shared library so it can be consumed from both mobile and extension.What is the current state of things and why does it need to change?
There is inconsistent and multiple one-off implementations for fiat currency and token formatting in the mobile and extension clients
What is the solution your changes offer and how does it work?
Create a shared set of formatters that aligns mobile and extension.
References
Checklist