CI: INFRA-2087 auto generated issues for mobile and extension repositories #4763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrabenda
commented
Oct 4, 2024
rrabenda
commented
Oct 4, 2024
rrabenda
commented
Oct 4, 2024
rrabenda
force-pushed
the
feat/INFRA-2087-auto-generate-issues
branch
from
8e95e76 to
dc8c828
Compare
rrabenda
commented
Oct 4, 2024
Gudahtt
previously requested changes
Oct 4, 2024
rrabenda
commented
Oct 10, 2024
Gudahtt
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Thoughts on mapping each controller to an array of team labels, rather than just one? Many of them have multiple code owners. Choosing just one for the label seems a bit arbitrary.
Gudahtt
reviewed
Oct 11, 2024
Gudahtt
reviewed
Oct 11, 2024
Gudahtt
reviewed
Oct 11, 2024
Gudahtt
reviewed
Oct 11, 2024
makemesteaks
previously approved these changes
Oct 25, 2024
Gudahtt
reviewed
Nov 1, 2024
Gudahtt
reviewed
Nov 1, 2024
Gudahtt
force-pushed
the
feat/INFRA-2087-auto-generate-issues
branch
from
c1d6100 to
5dce762
Compare
Gudahtt
reviewed
Nov 1, 2024
cryptodev-2s
approved these changes
Nov 1, 2024
4 tasks
Gudahtt
added a commit
that referenced
this pull request
Nov 1, 2024
## Explanation The `create-update-issues` workflow was failing because it didn't have access to the secrets it needed. The `CORE_CREATE_UPDATE_ISSUES_TOKEN` secret is only available on hte `default-branch` environment. The workflow has been updated to use that environment so that it may access the secret. Example failure: https://github.com/MetaMask/core/actions/runs/11633589453/job/32399521142 ## References Fixes bug introduced in #4763 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
CI pipeline for auto generated issues when major release of any package occurs. New issues will be created in metamask-extension and metamask-mobile repositories.
References
Changelog
None