-
-
Notifications
You must be signed in to change notification settings - Fork 251
CI: INFRA-2087 auto generated issues for mobile and extension repositories #4763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a464f6f
INFRA-2087 auto generated issues for mobile and extension repositories
fd0b04d
INFRA-2087 spellcheck fix
fd1c41a
INFRA-2087 spellcheck fix 2
11111df
INFRA-2087 auto generated issues for mobile and extension repositories 2
c10403c
INFRA-2087 auto generated issues for mobile and extension repositories 3
aba1f2c
INFRA-2087 auto generated issues for mobile and extension repositories 4
8ee08c8
INFRA-2087 add missing team-product-safety team
f53a2c8
INFRA-2087 add teams lists for labels creation
7896f3c
INFRA-2087 add teams lists for labels creation 2
e568e6a
Replace test repository targets with real targets
Gudahtt 973fd5a
Fix typo
Gudahtt 47aff03
Add note about keeping files synchronized
Gudahtt db1ce5e
Update teams.json to reflect joint team ownership
Gudahtt 49e55df
Rename token
Gudahtt 5dce762
Rename again to match pre-existing token
Gudahtt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
name: Create Update Issues | ||
|
||
on: | ||
workflow_call: | ||
secrets: | ||
CORE_CREATE_UPDATE_ISSUES_TOKEN: | ||
description: GitHub token with permission to create issues in both mobile and extension repositories | ||
required: true | ||
|
||
jobs: | ||
create-update-issues: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout head | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-tags: true | ||
|
||
- name: Create Issues | ||
env: | ||
GH_TOKEN: ${{ secrets.CORE_CREATE_UPDATE_ISSUES_TOKEN }} | ||
run: | | ||
IFS=$'\n' read -r -d '' -a tag_array < <(git tag --points-at HEAD && printf '\0') | ||
|
||
for tag in "${tag_array[@]}"; do | ||
if [[ "${tag}" == @metamask/* ]] ; then | ||
# Extract package name without the leading '@' | ||
package_name="${tag#@}" | ||
package_name="${package_name%@*}" | ||
|
||
# Extract version number | ||
version="${tag##*@}" | ||
|
||
# Check if version number ends with .0.0 | ||
if [[ $version == *.0.0 ]]; then | ||
# Fetch responsible team from file | ||
teams=$(jq -r --arg key "$package_name" '.[$key]' teams.json) | ||
gh issue create --title "Update ${package_name} to version ${version}" --body "Please update ${package_name} to version ${version}" --repo "MetaMask/metamask-extension" --label "$teams" | ||
gh issue create --title "Update ${package_name} to version ${version}" --body "Please update ${package_name} to version ${version}" --repo "MetaMask/metamask-mobile" --label "$teams" | ||
fi | ||
fi | ||
done | ||
shell: bash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
{ | ||
"metamask/accounts-controller": "team-accounts", | ||
"metamask/address-book-controller": "team-confirmations", | ||
"metamask/announcement-controller": "team-wallet-ux", | ||
"metamask/approval-controller": "team-confirmations", | ||
"metamask/assets-controllers": "team-assets", | ||
"metamask/base-controller": "team-wallet-framework", | ||
"metamask/build-utils": "team-wallet-framework", | ||
"metamask/chain-controller": "team-accounts", | ||
"metamask/composable-controller": "team-wallet-framework", | ||
"metamask/controller-utils": "team-wallet-framework", | ||
"metamask/ens-controller": "team-confirmations", | ||
"metamask/eth-json-rpc-provider": "team-wallet-api-platform,team-wallet-framework", | ||
"metamask/gas-fee-controller": "team-confirmations", | ||
"metamask/json-rpc-engine": "team-wallet-api-platform,team-wallet-framework", | ||
"metamask/json-rpc-middleware-stream": "team-wallet-api-platform,team-wallet-framework", | ||
"metamask/keyring-controller": "team-accounts", | ||
"metamask/logging-controller": "team-confirmations", | ||
"metamask/message-manager": "team-confirmations", | ||
"metamask/name-controller": "team-confirmations", | ||
"metamask/network-controller": "team-wallet-framework,team-assets", | ||
"metamask/notification-controller": "team-snaps-platform", | ||
"metamask/notification-services-controller": "team-notifications", | ||
"metamask/permission-controller": "team-wallet-api-platform,team-wallet-framework,team-snaps-platform", | ||
"metamask/permission-log-controller": "team-wallet-api-platform,team-wallet-framework", | ||
"metamask/phishing-controller": "team-product-safety", | ||
"metamask/polling-controller": "team-wallet-framework", | ||
"metamask/preferences-controller": "team-wallet-framework", | ||
"metamask/profile-sync-controller": "team-notifications", | ||
"metamask/queued-request-controller": "team-wallet-api-platform", | ||
"metamask/rate-limit-controller": "team-snaps-platform", | ||
"metamask/selected-network-controller": "team-wallet-api-platform,team-wallet-framework,team-assets", | ||
"metamask/signature-controller": "team-confirmations", | ||
"metamask/transaction-controller": "team-confirmations", | ||
"metamask/user-operation-controller": "team-confirmations" | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on mapping each controller to an array of team labels, rather than just one? Many of them have multiple code owners. Choosing just one for the label seems a bit arbitrary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in ad9b711