Skip to content

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 1, 2024

Explanation

The create-update-issues workflow was failing because it didn't have access to the secrets it needed. The CORE_CREATE_UPDATE_ISSUES_TOKEN secret is only available on hte default-branch environment.

The workflow has been updated to use that environment so that it may access the secret.

Example failure: https://github.com/MetaMask/core/actions/runs/11633589453/job/32399521142

References

Fixes bug introduced in #4763

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

The `create-update-issues` workflow was failing because it didn't have
access to the secrets it needed. The `CORE_CREATE_UPDATE_ISSUES_TOKEN`
secret is only available on hte `default-branch` environment.

The workflow has been updated to use that environment so that it may
access the secret.
@Gudahtt Gudahtt marked this pull request as ready for review November 1, 2024 17:52
@Gudahtt Gudahtt requested a review from a team as a code owner November 1, 2024 17:52
@Gudahtt Gudahtt enabled auto-merge (squash) November 1, 2024 17:54
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@Gudahtt Gudahtt merged commit 6814f82 into main Nov 1, 2024
120 checks passed
@Gudahtt Gudahtt deleted the fix-create-issues-workflow branch November 1, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants