chore: align ethereumjs versions #5347

matthewwalsh0 · 2025-02-14T23:09:11Z

Explanation

Align @ethereumjs/* package versions to avoid any risk of incompatibility and simplify future maintenance.

Upgrade originally required by @metamask/transaction-controller to support EIP-7702 transactions.

References

@metamask/accounts PR

Changelog

See changelogs.

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've highlighted breaking changes using the "BREAKING" category above as appropriate
I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

packages/keyring-controller/src/KeyringController.test.ts

matthewwalsh0 · 2025-02-27T20:51:56Z

@metamaskbot publish-preview

github-actions · 2025-02-27T20:56:19Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/accounts-controller": "24.1.0-preview-4a9b4a93",
  "@metamask-previews/address-book-controller": "6.0.3-preview-4a9b4a93",
  "@metamask-previews/announcement-controller": "7.0.3-preview-4a9b4a93",
  "@metamask-previews/approval-controller": "7.1.3-preview-4a9b4a93",
  "@metamask-previews/assets-controllers": "51.0.2-preview-4a9b4a93",
  "@metamask-previews/base-controller": "8.0.0-preview-4a9b4a93",
  "@metamask-previews/bridge-controller": "1.0.0-preview-4a9b4a93",
  "@metamask-previews/bridge-status-controller": "1.0.0-preview-4a9b4a93",
  "@metamask-previews/build-utils": "3.0.3-preview-4a9b4a93",
  "@metamask-previews/composable-controller": "11.0.0-preview-4a9b4a93",
  "@metamask-previews/controller-utils": "11.5.0-preview-4a9b4a93",
  "@metamask-previews/earn-controller": "0.5.0-preview-4a9b4a93",
  "@metamask-previews/ens-controller": "15.0.2-preview-4a9b4a93",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-4a9b4a93",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-4a9b4a93",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-4a9b4a93",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-4a9b4a93",
  "@metamask-previews/keyring-controller": "19.2.1-preview-4a9b4a93",
  "@metamask-previews/logging-controller": "6.0.4-preview-4a9b4a93",
  "@metamask-previews/message-manager": "12.0.1-preview-4a9b4a93",
  "@metamask-previews/multichain": "3.0.0-preview-4a9b4a93",
  "@metamask-previews/multichain-network-controller": "0.1.2-preview-4a9b4a93",
  "@metamask-previews/multichain-transactions-controller": "0.5.0-preview-4a9b4a93",
  "@metamask-previews/name-controller": "8.0.3-preview-4a9b4a93",
  "@metamask-previews/network-controller": "22.2.1-preview-4a9b4a93",
  "@metamask-previews/notification-services-controller": "1.0.0-preview-4a9b4a93",
  "@metamask-previews/permission-controller": "11.0.6-preview-4a9b4a93",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-4a9b4a93",
  "@metamask-previews/phishing-controller": "12.4.0-preview-4a9b4a93",
  "@metamask-previews/polling-controller": "12.0.3-preview-4a9b4a93",
  "@metamask-previews/preferences-controller": "15.0.2-preview-4a9b4a93",
  "@metamask-previews/profile-sync-controller": "8.1.1-preview-4a9b4a93",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-4a9b4a93",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-4a9b4a93",
  "@metamask-previews/remote-feature-flag-controller": "1.5.0-preview-4a9b4a93",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-4a9b4a93",
  "@metamask-previews/signature-controller": "23.2.1-preview-4a9b4a93",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-4a9b4a93",
  "@metamask-previews/transaction-controller": "46.0.0-preview-4a9b4a93",
  "@metamask-previews/user-operation-controller": "25.0.0-preview-4a9b4a93"
}

…chore/upgrade-ethereumjs

matthewwalsh0 · 2025-03-03T12:25:43Z

@metamaskbot publish-preview

socket-security · 2025-03-03T12:31:25Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/eth-hd-keyring@12.0.0	None	`0`	143 kB	metamaskbot
npm/@metamask/eth-simple-keyring@10.0.0	None	`0`	80.6 kB	metamaskbot
npm/@metamask/eth-snap-keyring@12.0.0	Transitive: environment, network	`+33`	7.72 MB	metamaskbot
npm/@metamask/keyring-internal-api@6.0.0	Transitive: environment, filesystem	`+16`	3.04 MB	metamaskbot
npm/@metamask/keyring-utils@3.0.0	Transitive: environment, network	`+22`	6.47 MB	metamaskbot

View full report↗︎

matthewwalsh0 · 2025-03-03T20:23:53Z

@metamaskbot publish-preview

github-actions · 2025-03-03T20:28:23Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/accounts-controller": "24.1.0-preview-4b0cb25d",
  "@metamask-previews/address-book-controller": "6.0.3-preview-4b0cb25d",
  "@metamask-previews/announcement-controller": "7.0.3-preview-4b0cb25d",
  "@metamask-previews/approval-controller": "7.1.3-preview-4b0cb25d",
  "@metamask-previews/assets-controllers": "51.0.2-preview-4b0cb25d",
  "@metamask-previews/base-controller": "8.0.0-preview-4b0cb25d",
  "@metamask-previews/bridge-controller": "2.0.0-preview-4b0cb25d",
  "@metamask-previews/bridge-status-controller": "2.0.0-preview-4b0cb25d",
  "@metamask-previews/build-utils": "3.0.3-preview-4b0cb25d",
  "@metamask-previews/composable-controller": "11.0.0-preview-4b0cb25d",
  "@metamask-previews/controller-utils": "11.5.0-preview-4b0cb25d",
  "@metamask-previews/earn-controller": "0.5.0-preview-4b0cb25d",
  "@metamask-previews/ens-controller": "15.0.2-preview-4b0cb25d",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-4b0cb25d",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-4b0cb25d",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-4b0cb25d",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-4b0cb25d",
  "@metamask-previews/keyring-controller": "19.2.1-preview-4b0cb25d",
  "@metamask-previews/logging-controller": "6.0.4-preview-4b0cb25d",
  "@metamask-previews/message-manager": "12.0.1-preview-4b0cb25d",
  "@metamask-previews/multichain": "3.0.0-preview-4b0cb25d",
  "@metamask-previews/multichain-network-controller": "0.1.2-preview-4b0cb25d",
  "@metamask-previews/multichain-transactions-controller": "0.5.0-preview-4b0cb25d",
  "@metamask-previews/name-controller": "8.0.3-preview-4b0cb25d",
  "@metamask-previews/network-controller": "22.2.1-preview-4b0cb25d",
  "@metamask-previews/notification-services-controller": "1.0.0-preview-4b0cb25d",
  "@metamask-previews/permission-controller": "11.0.6-preview-4b0cb25d",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-4b0cb25d",
  "@metamask-previews/phishing-controller": "12.4.0-preview-4b0cb25d",
  "@metamask-previews/polling-controller": "12.0.3-preview-4b0cb25d",
  "@metamask-previews/preferences-controller": "15.0.2-preview-4b0cb25d",
  "@metamask-previews/profile-sync-controller": "8.1.1-preview-4b0cb25d",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-4b0cb25d",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-4b0cb25d",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-4b0cb25d",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-4b0cb25d",
  "@metamask-previews/signature-controller": "23.2.1-preview-4b0cb25d",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-4b0cb25d",
  "@metamask-previews/transaction-controller": "46.0.0-preview-4b0cb25d",
  "@metamask-previews/user-operation-controller": "25.0.0-preview-4b0cb25d"
}

packages/assets-controllers/src/Standards/ERC20Standard.test.ts

packages/keyring-controller/src/KeyringController.test.ts

packages/assets-controllers/src/Standards/ERC20Standard.ts

ccharly

LGTM for accounts-related files.

packages/multichain-transactions-controller/CHANGELOG.md

mikesposito

LGTM!

Align versions

7ac23a6

matthewwalsh0 added the team-confirmations label Feb 14, 2025

matthewwalsh0 added 6 commits February 14, 2025 23:23

Fix unit tests

48cae7b

Fix linting

772101d

Update changelogs

325d4c9

Fix unit test

3a9b37e

Merge branch 'main' into chore/upgrade-ethereumjs

4f15ad2

Fix changelog

c0e7168

matthewwalsh0 marked this pull request as ready for review February 15, 2025 00:47

matthewwalsh0 requested review from a team as code owners February 15, 2025 00:47

danroc reviewed Feb 17, 2025

View reviewed changes

packages/keyring-controller/src/KeyringController.test.ts Outdated Show resolved Hide resolved

matthewwalsh0 and others added 7 commits February 26, 2025 11:04

Merge branch 'main' into chore/upgrade-ethereumjs

9c5ea25

Use accounts preview builds

9823377

chore: bump keyring packages

4dabc7d

bump other controllers

f322f64

fix profile-sync-controller tests

0d8e656

Update eslint-warning-thresholds.json

b8f2930

Merge branch 'mikesposito/bump-keyrings' into chore/upgrade-ethereumjs

499b800

matthewwalsh0 requested review from a team as code owners February 27, 2025 17:23

matthewwalsh0 changed the base branch from main to mikesposito/bump-keyrings February 27, 2025 17:25

Fix linting

4a9b4a9

Fix changelogs

bb7863d

matthewwalsh0 added the DO-NOT-MERGE label Feb 28, 2025

update changelogs

23a52a9

Use real versions

a7cf0a6

matthewwalsh0 requested review from a team as code owners March 3, 2025 09:46

matthewwalsh0 requested a review from a team March 3, 2025 09:46

mikesposito and others added 2 commits March 3, 2025 11:01

Merge branch 'main' into mikesposito/bump-keyrings

91dd836

Merge remote-tracking branch 'origin/mikesposito/bump-keyrings' into …

a0f0d77

…chore/upgrade-ethereumjs

Update keyring-internal-api version

d0de840

Base automatically changed from mikesposito/bump-keyrings to main March 3, 2025 14:28

Merge remote-tracking branch 'origin/main' into chore/upgrade-ethereumjs

47033f3

matthewwalsh0 removed the DO-NOT-MERGE label Mar 3, 2025

Update changelogs

4b0cb25

ccharly reviewed Mar 4, 2025

View reviewed changes

packages/assets-controllers/src/Standards/ERC20Standard.test.ts Outdated Show resolved Hide resolved

packages/keyring-controller/src/KeyringController.test.ts Show resolved Hide resolved

matthewwalsh0 added 4 commits March 5, 2025 10:53

Fix unit test

d5d210a

Merge branch 'main' into chore/upgrade-ethereumjs

3c1ec84

Fix getTokenSymbol

1480337

Merge branch 'main' into chore/upgrade-ethereumjs

6cb4b5d

ccharly reviewed Mar 5, 2025

View reviewed changes

packages/assets-controllers/src/Standards/ERC20Standard.ts Show resolved Hide resolved

ccharly approved these changes Mar 5, 2025

View reviewed changes

matthewwalsh0 enabled auto-merge (squash) March 5, 2025 17:08

mirceanis approved these changes Mar 5, 2025

View reviewed changes

OGPoyraz approved these changes Mar 5, 2025

View reviewed changes

matthewwalsh0 commented Mar 5, 2025

View reviewed changes

packages/multichain-transactions-controller/CHANGELOG.md Show resolved Hide resolved

Prithpal-Sooriya approved these changes Mar 5, 2025

View reviewed changes

mikesposito approved these changes Mar 5, 2025

View reviewed changes

matthewwalsh0 merged commit 1c9b6ca into main Mar 5, 2025
136 checks passed

matthewwalsh0 deleted the chore/upgrade-ethereumjs branch March 5, 2025 17:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: align ethereumjs versions #5347

chore: align ethereumjs versions #5347

Uh oh!

matthewwalsh0 commented Feb 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

matthewwalsh0 commented Feb 27, 2025

Uh oh!

github-actions bot commented Feb 27, 2025

Uh oh!

matthewwalsh0 commented Mar 3, 2025

Uh oh!

socket-security bot commented Mar 3, 2025 •

edited

Loading

Uh oh!

matthewwalsh0 commented Mar 3, 2025

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccharly left a comment

Uh oh!

Uh oh!

mikesposito left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chore: align ethereumjs versions #5347

chore: align ethereumjs versions #5347

Uh oh!

Conversation

matthewwalsh0 commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Changelog

Checklist

Uh oh!

Uh oh!

matthewwalsh0 commented Feb 27, 2025

Uh oh!

github-actions bot commented Feb 27, 2025

Uh oh!

matthewwalsh0 commented Mar 3, 2025

Uh oh!

socket-security bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthewwalsh0 commented Mar 3, 2025

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccharly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mikesposito left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

matthewwalsh0 commented Feb 14, 2025 •

edited

Loading

socket-security bot commented Mar 3, 2025 •

edited

Loading