Chore/bridge bridge status superstruct #5408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feat/bridge-and-bridgeStatus-state-changes
to
main
February 27, 2025 22:19
infiniteflower
force-pushed
the
chore/bridge-bridgeStatus-superstruct
branch
from
7a7a917 to
9bae550
Compare
amitabh94
approved these changes
Feb 27, 2025
| const url = `${BRIDGE_STATUS_BASE_URL}?${params.toString()}`; | ||
|
|
||
| const rawTxStatus = await fetchFn(url, { | ||
| const rawTxStatus: unknown = await fetchFn(url, { |
There was a problem hiding this comment.
Nice improvement in type safety by explicitly marking API responses as unknown before validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR refactors the
BridgeControllerandBridgeStatusControllerto use Superstruct for increased readability of API response validators.References
Changelog
@metamask/bridge-controller@metamask/bridge-status-controllerChecklist