Skip to content

Conversation

Julink-eth
Copy link
Contributor

@Julink-eth Julink-eth commented Mar 5, 2025

Explanation

Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes:

  • What is the current state of things and why does it need to change?
    The MM extension uses the NetworkConfiguration to store the network's properties in the store, there is a need for the extension to retrieve the new MM portfolio ecosystem page URL that will go live soon. There will be one page dedicated by network following this route format: https://portfolio.metamask.io/explore/networks/{networkName}
  • What is the solution your changes offer and how does it work?
    This solution makes it possible to configure the page's url for a network, it's also optional as there won't be a page for every network.
  • Are there any changes whose purpose might not obvious to those unfamiliar with the domain?
    No
  • If your primary goal was to update one package but you found you had to update another one along the way, why did you do so?
    I had to update the network-controller package for the configuration type itself but also the multichain-network-controller to change the function toMultichainNetworkConfiguration as this configuration can be applied to non EVM chains as well.
  • If you had to upgrade a dependency, why did you do so?
    No dependency upgrade

References

Are there any issues that this pull request is tied to? No
Are there other links that reviewers should consult to understand these changes better?
Yes this is the PR that being currently worked on to add the ecosystem page in Portfolio: https://github.com/consensys-vertical-apps/metamask-portfolio/pull/1534
Are there client or consumer pull requests to adopt any breaking changes?
No breaking changes but the MM extension will consume this change: MetaMask/metamask-extension#30777

For example:

Changelog

If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide.

(CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.)

Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods).

If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes.

Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None".

@metamask/network-controller

  • ADDED: portfolioDiscoverUrl a new optional property for the NetworkConfiguration type

@metamask/multichain-network-controller

  • ADDED: portfolioDiscoverUrl a new optional property for the CommonNetworkConfiguration type
  • CHANGED: toMultichainNetworkConfiguration function to take into account the new property portfolioDiscoverUrl

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@cryptodev-2s
Copy link
Contributor

@Julink-eth I see that you have checked I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes can you share the pull requests ?

@Julink-eth
Copy link
Contributor Author

Julink-eth commented Mar 6, 2025

Are there client or consumer pull requests to adopt any breaking changes?
No breaking changes but the MM extension will consume this change: MetaMask/metamask-extension#30777

Hello!
It's in the References section of the PR, here is the link: MetaMask/metamask-extension#30777
It only concerns extension.
Also it's a change not a breaking change, should I untick the last 2 tickers ? (I thought we needed all ticks for the PR to be able to review)

 I've highlighted breaking changes using the "BREAKING" category above as appropriate
 I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Julink-eth
Copy link
Contributor Author

Closing this PR as we have decided to just use a hash map hardcoded in the clients instead of using the MM state for those URLs.

@Julink-eth Julink-eth closed this Mar 11, 2025
@Julink-eth Julink-eth deleted the add-network-discover-page-url branch September 11, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants