fix: prevent undefined or empty currencies from being queried #5458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
CurrencyRateController
was getting an unexpected error when theNetworkController.networkConfigurationsByChainId
state included any configuration withnativeCurrency
set asundefined
.The easiest way to prevent this error, as well as to avoid unnecessary results from the API that returns currency rates, is to filter out falsy values of
nativeCurrency
when updating currency rates.References
Changelog
@metamask/assets-controllers
nativeCurrency
skipped when updating currency rates.Checklist