-
-
Notifications
You must be signed in to change notification settings - Fork 249
Improve sample-controllers to be more useful examples #6168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
deac397
3d76ba7
0962c3e
e1dea00
c0b6e96
bb71b2d
5e343da
c4d0fc4
d73a7ba
7d53513
7e967d2
31fc78b
c7c20c1
b3f9796
44e100f
9d0799e
525c4d8
0240763
78d29c5
1ac6bcc
8f9a6b9
0abf441
07e80e8
e0e52b3
7a97b62
3754d4c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,10 @@ | ||
export type { | ||
SampleGasPricesServiceActions, | ||
SampleGasPricesServiceEvents, | ||
SampleGasPricesServiceMessenger, | ||
} from './sample-gas-prices-service/sample-gas-prices-service'; | ||
export type { SampleGasPricesServiceFetchGasPricesAction } from './sample-gas-prices-service/sample-gas-prices-service-method-action-types'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These import paths are a bit annoying, now that I look at it. I'm curious whether flattening them is a good idea. Maybe I'll make another PR that organizes these files better. |
||
export { SampleGasPricesService } from './sample-gas-prices-service/sample-gas-prices-service'; | ||
export type { | ||
SampleGasPricesControllerActions, | ||
SampleGasPricesControllerEvents, | ||
|
@@ -7,9 +14,10 @@ export type { | |
SampleGasPricesControllerStateChangeEvent, | ||
} from './sample-gas-prices-controller'; | ||
export { | ||
getDefaultSampleGasPricesControllerState, | ||
SampleGasPricesController, | ||
getDefaultSampleGasPricesControllerState, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This export was already present, but it was not ordered alphabetically. |
||
} from './sample-gas-prices-controller'; | ||
export type { SampleGasPricesControllerUpdateGasPricesAction } from './sample-gas-prices-controller-method-action-types'; | ||
export type { | ||
SamplePetnamesControllerActions, | ||
SamplePetnamesControllerEvents, | ||
|
@@ -18,8 +26,8 @@ export type { | |
SamplePetnamesControllerState, | ||
SamplePetnamesControllerStateChangeEvent, | ||
} from './sample-petnames-controller'; | ||
export { SamplePetnamesController } from './sample-petnames-controller'; | ||
export { | ||
SampleGasPricesService, | ||
type SampleAbstractGasPricesService, | ||
mcmire marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} from './sample-gas-prices-service'; | ||
SamplePetnamesController, | ||
getDefaultPetnamesControllerState, | ||
} from './sample-petnames-controller'; | ||
export type { SamplePetnamesControllerAssignPetnameAction } from './sample-petnames-controller-method-action-types'; |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/** | ||
* This file is auto generated by `scripts/generate-method-action-types.ts`. | ||
* Do not edit manually. | ||
*/ | ||
|
||
import type { SampleGasPricesController } from './sample-gas-prices-controller'; | ||
|
||
/** | ||
* Fetches the latest gas prices for the given chain and persists them to | ||
* state. | ||
* | ||
* @param args - The arguments to the function. | ||
* @param args.chainId - The chain ID for which to fetch gas prices. | ||
*/ | ||
export type SampleGasPricesControllerUpdateGasPricesAction = { | ||
type: `SampleGasPricesController:updateGasPrices`; | ||
handler: SampleGasPricesController['updateGasPrices']; | ||
}; | ||
|
||
/** | ||
* Union of all SampleGasPricesController action types. | ||
*/ | ||
export type SampleGasPricesControllerMethodActions = | ||
SampleGasPricesControllerUpdateGasPricesAction; |
Uh oh!
There was an error while loading. Please reload this page.