-
-
Notifications
You must be signed in to change notification settings - Fork 246
feat(account-tree-controller): add AccountsController:accountRenamed
event handling
#6251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mathieuartu
merged 8 commits into
main
from
feat/handle-account-renamed-legacy-account-sync
Aug 7, 2025
Merged
feat(account-tree-controller): add AccountsController:accountRenamed
event handling
#6251
mathieuartu
merged 8 commits into
main
from
feat/handle-account-renamed-legacy-account-sync
Aug 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event handling for legacy account sync compatibility
fabiobozzo
previously approved these changes
Aug 6, 2025
AccountsController:accountRenamed
event handling for legacy account sync compatibilityAccountsController:accountRenamed
event handling
fabiobozzo
previously approved these changes
Aug 7, 2025
ccharly
reviewed
Aug 7, 2025
ccharly
reviewed
Aug 7, 2025
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
ccharly
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds support for handling
AccountsController:accountRenamed
events inAccountTreeController
to maintain compatibility with both legacy account syncing and the multichain accounts state 1 implementation.AccountTreeController
now subscribes to and handlesAccountsController:accountRenamed
events. When an EVM account is renamed, the controller automatically updates the corresponding account group name if the group has a default name pattern ("Account X") but the account now has a custom name. This ensures that custom account names are reflected at the group level for better user experience.This change maintains support for legacy account syncing flows that depend on programmatic account renames while ensuring
AccountTreeController
state remains consistent with account renames even though the UI doesn't use the tree structure yet in multichain state 1.References
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-521
Changelog
Checklist