Skip to content

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Aug 6, 2025

Explanation

Changes

  • Require clients to pass in the can_submit property when publishing QuoteSelected, AllQuotesSorted, AllQuotesOpened and QuotesReceived events. The value should indicate whether the CTA button is enabled
  • Rename the InputChanged event's value property key to input_value

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@micaelae micaelae requested review from a team as code owners August 6, 2025 18:09
@micaelae micaelae marked this pull request as draft August 6, 2025 18:10
@micaelae micaelae changed the title fix: Unified Swap event properties fix: Unified Swap can_submit and input_value properties Aug 7, 2025
@micaelae micaelae marked this pull request as ready for review August 7, 2025 17:50
@micaelae micaelae enabled auto-merge (squash) August 7, 2025 19:36
@micaelae micaelae merged commit 744b146 into main Aug 7, 2025
223 checks passed
@micaelae micaelae deleted the swaps-event-todos branch August 7, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants