feat: Migrate next BaseController class to new Messenger package
#6318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
messenger-migrate-base-controller
branch
from
2b24ae4 to
52e6756
Compare
Gudahtt
force-pushed
the
create-next-base-controller-export
branch
from
5f65d0e to
afa4dc5
Compare
Gudahtt
force-pushed
the
messenger-migrate-base-controller
branch
4 times, most recently
from
6d9f187 to
513bb4b
Compare
Gudahtt
commented
Aug 19, 2025
| /** | ||
| * The controller messenger. This is used to interact with other parts of the application. | ||
| */ | ||
| protected messagingSystem: ControllerMessenger; |
There was a problem hiding this comment.
We agreed recently in Slack to rename this property, but this will be done in a later PR.
Gudahtt
commented
Aug 19, 2025
| * This is the same as the `messagingSystem` property, but has a type that only lets us use | ||
| * actions and events that are part of the `BaseController` class. | ||
| */ | ||
| readonly #messenger: Messenger< |
There was a problem hiding this comment.
I added a duplicate reference to the messenger here as a private instance variable just to avoid the need to cast it each time it's internally referenced.
Gudahtt
commented
Aug 19, 2025
| } | ||
| } | ||
|
|
||
| it('should allow messaging between controllers', () => { |
There was a problem hiding this comment.
This test has the best complete example so far
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cryptodev-2s
approved these changes
Aug 19, 2025
Gudahtt
changed the title
next BaseController class to new Messenger packagenext BaseController class to new Messenger package
Gudahtt
force-pushed
the
messenger-migrate-base-controller
branch
from
513bb4b to
ae71891
Compare
Gudahtt
force-pushed
the
messenger-migrate-base-controller
branch
from
ae71891 to
67c7853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Migrate the upcoming
BaseControllerclass to use the new@metamask/messengerpackage. This includes replacingRestrictedMessengerwith the newMessengerclass that supports delegation.References
Relates to #5626
Checklist