Skip to content

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Aug 14, 2025

Explanation

Release 502.0.0 contained some extra changes to the dependencies for assets-controllers that need to be reverted. Release 503.0.0 was created with the (reasonable) assumption that 502.0.0 had already been deployed. We need to revert both and then recreate 503.0.0 as 502.0.0.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Release 502.0.0 contained some extra changes to the dependencies for
`assets-controllers` that need to be reverted. Release 503.0.0 was
created with the (reasonable) assumption that 502.0.0 had already been
deployed. We need to revert both and then recreate 503.0.0 as 502.0.0.
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire marked this pull request as ready for review August 14, 2025 22:10
@mcmire mcmire requested review from a team as code owners August 14, 2025 22:10
@mcmire mcmire merged commit a888342 into main Aug 14, 2025
230 of 231 checks passed
@mcmire mcmire deleted the revert-release-502-and-503 branch August 14, 2025 22:10
},
"peerDependencies": {
"@metamask/account-tree-controller": "^0.9.0",
"@metamask/account-tree-controller": "^0.7.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dependency Mismatch Causes Resolution Issues

The assets-controllers package has an inconsistent dependency for @metamask/account-tree-controller. Its devDependencies specifies ^0.8.0, but peerDependencies is set to ^0.7.0. Since 0.8.0 falls outside the ^0.7.0 range, this mismatch can lead to dependency resolution problems and runtime issues for consumers.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants