feat: add alignment methods to group, wallet and service classes #6326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fabiobozzo
reviewed
Aug 18, 2025
fabiobozzo
approved these changes
Aug 18, 2025
gantunesr
reviewed
Aug 18, 2025
3 tasks
fabiobozzo
added a commit
that referenced
this pull request
Aug 27, 2025
## Explanation
### What is the current state and why does it need to change?
Currently, the `MultichainAccountService` has no mechanism to manage
provider states based on user preferences like the "basic functionality"
toggle. When users disable advanced features (basic functionality OFF),
all providers (EVM, Solana, Bitcoin, etc.) remain active and continue
creating multichain accounts, which goes against the user's preference
for a simplified wallet experience.
The extension's `PreferencesController` manages the basic functionality
toggle (`useExternalServices`), but there was no way to communicate this
state change to the core `MultichainAccountService` to disable
non-essential providers.
### What is the solution and how does it work?
This PR introduces a clean provider state management system that allows
clients to control which providers are active based on user preferences:
1. **Provider-Level Disable Mechanism**: Added `setDisabled(disabled:
boolean)` method to `BaseAccountProvider`. Providers now **can /
should** check `this.isDisabled` in their `createAccounts` methods and
return empty arrays when disabled, preventing new account creation.
2. `EvmAccountProvider` could be disabled, for other reasons in the
future, but does not depend on basic functionality, at all.
3. Added `setBasicFunctionality({ enabled: boolean })` method to
`MultichainAccountService` that:
- Calls `setDisabled(!enabled)` on all providers
- **Triggers wallet alignment when basic functionality is enabled to
ensure account groups are complete**
4. **Extension Integration**: The extension's `PreferencesController`
now calls this method when the basic functionality toggle changes.
## References
Alignment method provided by: #6326
Stories:
- [MUL-343](https://consensyssoftware.atlassian.net/browse/MUL-343)
- [MUL-525](https://consensyssoftware.atlassian.net/browse/MUL-525)
- [MUL-524](https://consensyssoftware.atlassian.net/browse/MUL-524)
## Checklist
- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
[MUL-343]:
https://consensyssoftware.atlassian.net/browse/MUL-343?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
---------
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
What is the current state of things and why does it need to change? An alignment mechanism didn't exist for multichain account groups. It needs to be added because we can have multiple scenarios where misalignment occurs:
What is the solution your changes offer and how does it work? It adds an alignment mechanism at the group level and it runs through the list of providers and checks to see if any accounts exist for that particular group, if there aren't any, then it calls
provider.createAccountswith the associated entropy id and group index. Alignment methods were added at the wallet level where a wallet would call align on all of its existing groups and similarly at the service level where it can call align on all of its wallets. Singular methods were also added at the wallet and service level where a particular group associated with a wallet can be aligned and a particular wallet can be aligned by the service.Note: I also refactored the
withCreateAccountinSnapAccountProviderto be a bit more readable and easier to understand.Checklist