feat(multichain-account-service): basic functionality management #6332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
gantunesr
reviewed
Aug 19, 2025
packages/multichain-account-service/src/providers/SolAccountProvider.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/BaseAccountProvider.ts
Outdated
Show resolved
Hide resolved
hmalik88
reviewed
Aug 19, 2025
packages/multichain-account-service/src/providers/BaseAccountProvider.ts
Outdated
Show resolved
Hide resolved
hmalik88
reviewed
Aug 19, 2025
hmalik88
reviewed
Aug 19, 2025
packages/multichain-account-service/src/MultichainAccountService.ts
Outdated
Show resolved
Hide resolved
hmalik88
reviewed
Aug 19, 2025
fabiobozzo
commented
Aug 19, 2025
packages/multichain-account-service/src/MultichainAccountService.ts
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ccharly
reviewed
Aug 26, 2025
packages/multichain-account-service/src/MultichainAccountService.test.ts
Outdated
Show resolved
Hide resolved
| * | ||
| * @param enabled - Whether basic functionality is enabled. | ||
| */ | ||
| async setBasicFunctionality(enabled: boolean): Promise<void> { |
There was a problem hiding this comment.
IDK if we should have this as part of the public API 🤔
My initial idea was to have the "account provider wrapper" to "react" to some events (or maybe a runtime callback) and adapt each of their methods to return all accounts or no accounts (based on the "basic functionality flag").
Though, I haven't checked of this was done on both clients, so maybe it's not that easy to do
There was a problem hiding this comment.
This is something to discuss @ccharly . It's an architectural decision, and I chose the simplest path (multichain account service was already available to both places where basicFunctionality is toggled in extension and mobile).
Are you suggesting we use MultichainAccountServiceMessenger to dispatch a MultichainAccountServiceSetBasicFunctionalityAction ? I'm not sure how to get a ref to that messenger in mobile tbh.
There was a problem hiding this comment.
Well, let's be pragmatic here and keep your implementation for now. It's simple enough and does get the job done, so that's ok! 👍
We can re-visit that later once we have a bit more time.
packages/multichain-account-service/src/providers/ProviderWrapper.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/ProviderWrapper.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/ProviderWrapper.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/ProviderWrapper.ts
Outdated
Show resolved
Hide resolved
ccharly
reviewed
Aug 26, 2025
packages/multichain-account-service/src/MultichainAccountService.ts
Outdated
Show resolved
Hide resolved
ccharly
reviewed
Aug 26, 2025
packages/multichain-account-service/src/providers/BaseAccountProvider.ts
Show resolved
Hide resolved
ccharly
reviewed
Aug 26, 2025
packages/multichain-account-service/src/providers/ProviderWrapper.ts
Outdated
Show resolved
Hide resolved
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
reviewed
Aug 27, 2025
packages/multichain-account-service/src/providers/AccountProviderWrapper.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountService.test.ts
Outdated
Show resolved
Hide resolved
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
reviewed
Aug 27, 2025
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
github-merge-queue bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Sep 3, 2025
…18472) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Add multichain account provider state management when basic functionality toggle changes on mobile. When users toggle the "Basic Functionality" setting on mobile, account providers need to be managed appropriately - non-EVM providers should be disabled when basic functionality is OFF, and all providers should be enabled with wallet alignment when basic functionality is ON. ## **Changelog** CHANGELOG entry: null This PR integrates with the `MultichainAccountService.setBasicFunctionality()` method to: - Update provider disabled states based on basic functionality preference - Trigger multichain wallet alignment when basic functionality is enabled 1. **BasicFunctionalityModal** - Main settings toggle modal 2. **ConfirmTurnOnBackupAndSyncModal** - Backup & sync confirmation flow Both now call `Engine.context.MultichainAccountService.setBasicFunctionality({ enabled })` after updating Redux state. ## **Related issues** [MUL-343](https://consensyssoftware.atlassian.net/browse/MUL-343) Relates to: MetaMask/metamask-extension#35190, MetaMask/core#6332 ## **Manual testing steps** Scenario: user enables basic functionality from settings Given basic functionality is currently disabled And user is in Settings > Security & Privacy > Basic Functionality When user toggles "Basic Functionality" to ON Then Redux state updates to basicFunctionalityEnabled: true And MultichainAccountService.setBasicFunctionality is called with enabled: true And console shows "MultichainAccountService: Setting basic functionality enabled" And console shows "Triggered wallet alignment..." And all multichain account providers are enabled --- Scenario: user disables basic functionality from settings Given basic functionality is currently enabled And user is in Settings > Security & Privacy > Basic Functionality When user toggles "Basic Functionality" to OFF Then confirmation modal appears When user confirms the action Then Redux state updates to basicFunctionalityEnabled: false And MultichainAccountService.setBasicFunctionality is called with enabled: false And console shows "MultichainAccountService: Setting basic functionality disabled" And EVM provider remains active And non-EVM providers (Solana, etc.) are disabled --- Scenario: user enables basic functionality via backup sync flow Given basic functionality is disabled And user is in backup & sync confirmation modal When user confirms "Turn On" Then MultichainAccountService.setBasicFunctionality is called with enabled: true And providers are enabled and alignment is triggered ## **Screenshots/Recordings** <img width="1127" height="1011" alt="image" src="https://github.com/user-attachments/assets/f5be2102-1b18-4b70-aee6-f36223d1be82" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [MUL-343]: https://consensyssoftware.atlassian.net/browse/MUL-343?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
What is the current state and why does it need to change?
Currently, the
MultichainAccountServicehas no mechanism to manage provider states based on user preferences like the "basic functionality" toggle. When users disable advanced features (basic functionality OFF), all providers (EVM, Solana, Bitcoin, etc.) remain active and continue creating multichain accounts, which goes against the user's preference for a simplified wallet experience.The extension's
PreferencesControllermanages the basic functionality toggle (useExternalServices), but there was no way to communicate this state change to the coreMultichainAccountServiceto disable non-essential providers.What is the solution and how does it work?
This PR introduces a clean provider state management system that allows clients to control which providers are active based on user preferences:
Provider-Level Disable Mechanism: Added
setDisabled(disabled: boolean)method toBaseAccountProvider. Providers now can / should checkthis.isDisabledin theircreateAccountsmethods and return empty arrays when disabled, preventing new account creation.EvmAccountProvidercould be disabled, for other reasons in the future, but does not depend on basic functionality, at all.Added
setBasicFunctionality({ enabled: boolean })method toMultichainAccountServicethat:setDisabled(!enabled)on all providersExtension Integration: The extension's
PreferencesControllernow calls this method when the basic functionality toggle changes.References
Alignment method provided by: #6326
Stories:
Checklist