feat: add backup & sync capabilities to AccountTreeController
#6344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
reviewed
Sep 9, 2025
packages/account-tree-controller/src/backup-and-sync/service/index.ts
Outdated
Show resolved
Hide resolved
ccharly
reviewed
Sep 9, 2025
packages/account-tree-controller/src/backup-and-sync/service/index.ts
Outdated
Show resolved
Hide resolved
ccharly
reviewed
Sep 9, 2025
ccharly
reviewed
Sep 9, 2025
ccharly
reviewed
Sep 9, 2025
packages/account-tree-controller/src/backup-and-sync/service/index.ts
Outdated
Show resolved
Hide resolved
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mathieuartu
commented
Sep 10, 2025
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
reviewed
Sep 10, 2025
packages/account-tree-controller/src/backup-and-sync/service/atomic-sync-queue.ts
Outdated
Show resolved
Hide resolved
packages/account-tree-controller/src/backup-and-sync/service/index.ts
Outdated
Show resolved
Hide resolved
packages/account-tree-controller/src/backup-and-sync/user-storage/network-operations.ts
Outdated
Show resolved
Hide resolved
ccharly
approved these changes
Sep 11, 2025
|
(small remark though, I haven't reviewed the tests entirely, but we have good coverage and have run multiple real-case manual scenarios with preview builds, so we're good) |
cmd-ob
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR introduces comprehensive backup and synchronization capabilities to
AccountTreeController, adding account tree data persistence and cross-device synchronization through user storage.It adds one new public method to
AccountTreeController,syncWithUserStorage, that is intended to replace every current occurence ofUserStorageController:syncInternalAccountsWithUserStoragein the clients.Legacy account syncing is still performed as a migration to multichain account syncing step, and is encompassed in this new
syncWithUserStoragepublic method.The implementation features a new
BackupAndSyncServicewith atomic sync queues, bidirectional metadata synchronization, and rollback mechanisms for failed operations.The service automatically triggers sync operations when users add and rename wallets/groups, change visibility states, or perform other metadata modifications. Analytics tracking and performance tracing provide observability into sync operations, while debug logging assists with troubleshooting sync issues.
It is worth noting that this PR also removes all account syncing code from
UserStorageController.References
Checklist