feat: Add additional controller metadata #6359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
add-additional-controller-metadata
branch
2 times, most recently
from
afdce57 to
f5cd542
Compare
Gudahtt
commented
Aug 25, 2025
Gudahtt
force-pushed
the
add-additional-controller-metadata
branch
from
f5cd542 to
10820ba
Compare
Gudahtt
force-pushed
the
add-additional-controller-metadata
branch
from
06c0400 to
b99bd0b
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Gudahtt
force-pushed
the
add-additional-controller-metadata
branch
from
7cb3f4f to
a09aedf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Gudahtt
force-pushed
the
add-additional-controller-metadata
branch
3 times, most recently
from
c254f4b to
4092ff4
Compare
mikesposito
reviewed
Sep 3, 2025
mcmire
reviewed
Sep 3, 2025
Add the `includeInStateLogs` and `usedInUi` state metadata properties, and rename `anonymous` to `includeInDebugSnapshot`. This is the implementation of the second option of this ADR: MetaMask/decisions#101 Related to MetaMask/decisions#101 Fixes #643
…ed metadata instead as a way to disallow deriver for usedInUi
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Gudahtt
force-pushed
the
add-additional-controller-metadata
branch
from
0dcdc73 to
50859de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Add the
includeInStateLogsandusedInUistate metadata properties. This is the implementation of the second option of this ADR: https://github.com/MetaMask/decisions/pull/101The
deriveStateFromMetadatafunction has also been exported, rather than adding two new exports for these new properties. The previous exported state derivation functions (getPersistedStateandgetAnonymizedState) have been deprecated in favour ofderiveStateFromMetadata.References
Related to https://github.com/MetaMask/decisions/pull/101
Fixes #6443
Checklist