Skip to content

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Aug 25, 2025

Explanation

This PR migrates the KeyringController controller class to the new @metamask/messenger comm system, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Gudahtt
Gudahtt previously approved these changes Aug 25, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!

@mikesposito mikesposito marked this pull request as ready for review August 25, 2025 13:25
@mikesposito mikesposito requested review from a team as code owners August 25, 2025 13:25
@mikesposito mikesposito mentioned this pull request Aug 22, 2025
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants