-
-
Notifications
You must be signed in to change notification settings - Fork 246
feat: add account discovery to MultichainAccountWallet
and providers
#6397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom discoverAndCreateAccounts
fabiobozzo
reviewed
Aug 29, 2025
fabiobozzo
reviewed
Aug 29, 2025
packages/multichain-account-service/src/providers/EvmAccountProvider.ts
Outdated
Show resolved
Hide resolved
fabiobozzo
reviewed
Aug 29, 2025
packages/multichain-account-service/src/providers/BaseAccountProvider.ts
Outdated
Show resolved
Hide resolved
fabiobozzo
previously approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ccharly
reviewed
Aug 29, 2025
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
…mock providers make no distinction between provider type, remove unnecessary assertions
ccharly
reviewed
Sep 4, 2025
packages/multichain-account-service/src/providers/EvmAccountProvider.test.ts
Show resolved
Hide resolved
danroc
reviewed
Sep 5, 2025
packages/multichain-account-service/src/providers/SolAccountProvider.ts
Outdated
Show resolved
Hide resolved
danroc
reviewed
Sep 5, 2025
packages/multichain-account-service/src/providers/EvmAccountProvider.ts
Outdated
Show resolved
Hide resolved
ccharly
reviewed
Sep 5, 2025
packages/multichain-account-service/src/MultichainAccountService.ts
Outdated
Show resolved
Hide resolved
danroc
reviewed
Sep 5, 2025
MultichainAccountWallet
and providers and add createMultichainAccountWallet
to the serviceMultichainAccountWallet
and providers
ccharly
reviewed
Sep 5, 2025
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/EvmAccountProvider.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/EvmAccountProvider.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/EvmAccountProvider.ts
Outdated
Show resolved
Hide resolved
ccharly
approved these changes
Sep 5, 2025
Kriys94
pushed a commit
that referenced
this pull request
Sep 8, 2025
#6397) ## Explanation ### EvmAccountProvider 1. `discoverAndCreateAccounts` method added to perform discovery and return the created account. The method will add an account to the keyring and remove it (except for `groupIndex` 0) if it is found there is no transaction history. 2. `getEvmProvider` method was added to grab the provider from the `NetworkController`. ### SolAccountProvider 1. `discoverAndCreateAccounts` method added to perform discovery and return the created account. This method does not create an account if discovery yields no accounts. 2. Added a `#getKeyringClientFromSnapId` method that initializes the keyring client into a newly added `#client` property. ### MultichainAccountWallet 1. `discoverAndCreateAccounts` method added to act as an orchestrator for provider discovery. This method "fast-forwards" lagging providers to the highest `groupIndex` being processed by a provider. At the end of discovery, it will sync the wallet and then align all created groups. The method returns only the discovered accounts (for consumption of the clients' metrics). ## References N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
EvmAccountProvider
discoverAndCreateAccounts
method added to perform discovery and return the created account. The method will add an account to the keyring and remove it (except forgroupIndex
0) if it is found there is no transaction history.getEvmProvider
method was added to grab the provider from theNetworkController
.SolAccountProvider
discoverAndCreateAccounts
method added to perform discovery and return the created account. This method does not create an account if discovery yields no accounts.#getKeyringClientFromSnapId
method that initializes the keyring client into a newly added#client
property.MultichainAccountWallet
discoverAndCreateAccounts
method added to act as an orchestrator for provider discovery. This method "fast-forwards" lagging providers to the highestgroupIndex
being processed by a provider. At the end of discovery, it will sync the wallet and then align all created groups. The method returns only the discovered accounts (for consumption of the clients' metrics).References
N/A
Checklist