refactor: fully extract middleware into EIP-5792 Middleware package #6477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ffmcgee725
added a commit
to MetaMask/eth-json-rpc-middleware
that referenced
this pull request
Sep 5, 2025
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
jiexi
reviewed
Sep 8, 2025
jiexi
reviewed
Sep 8, 2025
jiexi
reviewed
Sep 9, 2025
jiexi
reviewed
Sep 9, 2025
| * @param options - Configuration object containing the getAccounts function. | ||
| * @param options.getAccounts - Function to retrieve accounts for the requester. | ||
| * @returns A normalized (lowercase) hex address if valid and authorized. | ||
| * @throws JsonRpcError with unauthorized error if the requester doesn't have permission to access the address. |
There was a problem hiding this comment.
Suggested change
| * @throws JsonRpcError with unauthorized error if the requester doesn't have permission to access the address. | |
| * @throws JsonRpcError with unauthorized error if the requester doesn't have permission to access the address. |
jiexi
approved these changes
Sep 9, 2025
ffmcgee725
added a commit
to MetaMask/eth-json-rpc-middleware
that referenced
this pull request
Sep 10, 2025
…) package (#401) <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? Are there any issues or other links reviewers should consult to understand this pull request better? For instance: * Fixes #12345 * See: #67890 --> ## Explanation The newly created EIP-5792 Middleware package ([PR #6422](MetaMask/core#6422)) currently contains only the hooks required for the existing wallet middleware. To align with the intended abstraction and reduce the monolithic nature of wallet-middleware, we should fully extract the relevant middleware logic from eth-json-rpc-middleware ([GitHub - MetaMask/eth-json-rpc-middleware: Ethereum middleware for composing an Ethereum provider using json-rpc-engine. Intended to replace provider-engine](https://github.com/MetaMask/eth-json-rpc-middleware)) into this new package. This PR removes the identified middleware into @metamask/eip-5792-middleware. PR [#6477](MetaMask/core#6477) from https://github.com/MetaMask/core moves this middleware to the specified package. * Fixes https://consensyssoftware.atlassian.net/browse/WAPI-691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The newly created EIP-5792 Middleware package (PR #6422) currently contains only the hooks required for the existing wallet middleware. To align with the intended abstraction and reduce the monolithic nature of wallet-middleware, we should fully extract the relevant middleware logic from eth-json-rpc-middleware (GitHub - MetaMask/eth-json-rpc-middleware: Ethereum middleware for composing an Ethereum provider using json-rpc-engine. Intended to replace provider-engine) into this new package.
This PR moves the identified middleware into @metamask/eip-5792-middleware.
References
Checklist