-
-
Notifications
You must be signed in to change notification settings - Fork 246
fix(account-tree-controller): address group names consistency bug #6601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
d7a3248
fix(AccountTreeController): Fix critical multi-wallet naming bug
fabiobozzo 4fb2af9
docs: Update changelog with critical multi-wallet naming fix
fabiobozzo b64f14c
fix(ESLint): Fix prefer-destructuring and jest/no-conditional-in-test…
fabiobozzo b38ffe6
fix: Restore proper imports for MultichainAccountWalletStatus
fabiobozzo 081c4f0
fix: Correct per-wallet numbering and preserve EVM account names
fabiobozzo 927a774
fix: Simplify account naming fix to prevent extension crashes
fabiobozzo acd49d8
fix(lint): Fix ESLint formatting and import issues
fabiobozzo f495812
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo 90c4056
docs: Add PR link to changelog entry for #6601
fabiobozzo 87a65ea
fix(coverage): Add istanbul ignore for defensive fallback code
fabiobozzo d26532d
fix(changelog): Reorder sections to follow Keep a Changelog format
fabiobozzo 071a074
Update packages/account-tree-controller/CHANGELOG.md
fabiobozzo dca6f2d
Update packages/account-tree-controller/src/AccountTreeController.ts
fabiobozzo 1c7c0df
address pr remarks
fabiobozzo e2a474b
address pr remarks
fabiobozzo a512217
add scenario based on pr suggestion
fabiobozzo 0ef2ffa
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo b87494a
refactor: address charly comments on scalability and conflict resolution
fabiobozzo 7d4e7dc
fix lint errors in test
fabiobozzo 66fd0a9
refactor: optimize account naming logic to reduce conflict checks
fabiobozzo c2fe321
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo e75b4e6
adjusted the starting point for account group naming in the implement…
fabiobozzo a4a2709
feat: implement automatic conflict resolution for account group naming
fabiobozzo 3efc670
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo 9ece24c
test: add unit test for autoHandleConflict functionality in account g…
fabiobozzo 70554ef
refactor: update name conflict resolution logic in AccountTreeController
fabiobozzo 661b091
refactor: address pr remarks
fabiobozzo d3cb731
test: remove obsolete test for group ID error handling in AccountTree…
fabiobozzo 9873b6e
test: achieve 100% test coverage with istanbul ignore for edge cases
fabiobozzo 87573cd
Update packages/account-tree-controller/CHANGELOG.md
fabiobozzo 44600fd
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo 7e6f701
refactor: address latest PR feedback from Charly
fabiobozzo 4aa81d4
fix: implement +1 logic for highest account name index
fabiobozzo 04239c5
refactor: use assert from @metamask/utils for invariant checking
fabiobozzo 39557d3
refactor: clean up AccountTreeController test file
fabiobozzo 156becd
docs: update changelog for account tree controller improvements
fabiobozzo 5935c76
test: update expectations for new +1 naming logic
fabiobozzo 986114e
tiny comment change
fabiobozzo e47a278
refactor: use passed state parameter in applyAccountGroupMetadata
fabiobozzo ddb42e1
test: fix remaining test expectations for new naming behavior
fabiobozzo 9d37632
fix: revert problematic +1 logic to restore proper sequential naming
fabiobozzo 6a7184b
fix: remove duplicate changelog entries for released version
fabiobozzo 47b4e4a
fix changelog
fabiobozzo ede8d24
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo 34d02af
fix: correct changelog section ordering for validation
fabiobozzo d0a9e96
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo fc9ff35
fix(account-tree-controller): use state.wallets in group metadata app…
fabiobozzo c43a1d3
every state mutation must pick a ref from state itself
fabiobozzo 646fc06
group metadata name assignment to directly access state.accountTree.w…
fabiobozzo 5bc89b3
fix: implement per-wallet sequential account naming
fabiobozzo 895007a
tiny changelog edit
fabiobozzo 7d0c219
replace nullish coalescing assignment with direct assignment for acco…
fabiobozzo d243c52
Update packages/account-tree-controller/CHANGELOG.md
fabiobozzo 38e0b5a
update tests to reflect new naming logic and ensure accuracy in accou…
fabiobozzo a6ec434
ignore testing init accountGroupsMetadata for groupId if it doesn't e…
fabiobozzo ffe2350
prettify
fabiobozzo 3cc47b4
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.