Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
d7a3248
fix(AccountTreeController): Fix critical multi-wallet naming bug
fabiobozzo Sep 15, 2025
4fb2af9
docs: Update changelog with critical multi-wallet naming fix
fabiobozzo Sep 15, 2025
b64f14c
fix(ESLint): Fix prefer-destructuring and jest/no-conditional-in-test…
fabiobozzo Sep 15, 2025
b38ffe6
fix: Restore proper imports for MultichainAccountWalletStatus
fabiobozzo Sep 15, 2025
081c4f0
fix: Correct per-wallet numbering and preserve EVM account names
fabiobozzo Sep 15, 2025
927a774
fix: Simplify account naming fix to prevent extension crashes
fabiobozzo Sep 15, 2025
acd49d8
fix(lint): Fix ESLint formatting and import issues
fabiobozzo Sep 15, 2025
f495812
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo Sep 15, 2025
90c4056
docs: Add PR link to changelog entry for #6601
fabiobozzo Sep 15, 2025
87a65ea
fix(coverage): Add istanbul ignore for defensive fallback code
fabiobozzo Sep 15, 2025
d26532d
fix(changelog): Reorder sections to follow Keep a Changelog format
fabiobozzo Sep 15, 2025
071a074
Update packages/account-tree-controller/CHANGELOG.md
fabiobozzo Sep 15, 2025
dca6f2d
Update packages/account-tree-controller/src/AccountTreeController.ts
fabiobozzo Sep 15, 2025
1c7c0df
address pr remarks
fabiobozzo Sep 15, 2025
e2a474b
address pr remarks
fabiobozzo Sep 15, 2025
a512217
add scenario based on pr suggestion
fabiobozzo Sep 15, 2025
0ef2ffa
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo Sep 15, 2025
b87494a
refactor: address charly comments on scalability and conflict resolution
fabiobozzo Sep 15, 2025
7d4e7dc
fix lint errors in test
fabiobozzo Sep 15, 2025
66fd0a9
refactor: optimize account naming logic to reduce conflict checks
fabiobozzo Sep 16, 2025
c2fe321
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo Sep 16, 2025
e75b4e6
adjusted the starting point for account group naming in the implement…
fabiobozzo Sep 16, 2025
a4a2709
feat: implement automatic conflict resolution for account group naming
fabiobozzo Sep 16, 2025
3efc670
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo Sep 16, 2025
9ece24c
test: add unit test for autoHandleConflict functionality in account g…
fabiobozzo Sep 17, 2025
70554ef
refactor: update name conflict resolution logic in AccountTreeController
fabiobozzo Sep 17, 2025
661b091
refactor: address pr remarks
fabiobozzo Sep 17, 2025
d3cb731
test: remove obsolete test for group ID error handling in AccountTree…
fabiobozzo Sep 17, 2025
9873b6e
test: achieve 100% test coverage with istanbul ignore for edge cases
fabiobozzo Sep 17, 2025
87573cd
Update packages/account-tree-controller/CHANGELOG.md
fabiobozzo Sep 18, 2025
44600fd
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo Sep 18, 2025
7e6f701
refactor: address latest PR feedback from Charly
fabiobozzo Sep 18, 2025
4aa81d4
fix: implement +1 logic for highest account name index
fabiobozzo Sep 18, 2025
04239c5
refactor: use assert from @metamask/utils for invariant checking
fabiobozzo Sep 18, 2025
39557d3
refactor: clean up AccountTreeController test file
fabiobozzo Sep 18, 2025
156becd
docs: update changelog for account tree controller improvements
fabiobozzo Sep 18, 2025
5935c76
test: update expectations for new +1 naming logic
fabiobozzo Sep 18, 2025
986114e
tiny comment change
fabiobozzo Sep 18, 2025
e47a278
refactor: use passed state parameter in applyAccountGroupMetadata
fabiobozzo Sep 18, 2025
ddb42e1
test: fix remaining test expectations for new naming behavior
fabiobozzo Sep 18, 2025
9d37632
fix: revert problematic +1 logic to restore proper sequential naming
fabiobozzo Sep 18, 2025
6a7184b
fix: remove duplicate changelog entries for released version
fabiobozzo Sep 18, 2025
47b4e4a
fix changelog
fabiobozzo Sep 18, 2025
ede8d24
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo Sep 18, 2025
34d02af
fix: correct changelog section ordering for validation
fabiobozzo Sep 18, 2025
d0a9e96
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo Sep 19, 2025
fc9ff35
fix(account-tree-controller): use state.wallets in group metadata app…
fabiobozzo Sep 19, 2025
c43a1d3
every state mutation must pick a ref from state itself
fabiobozzo Sep 19, 2025
646fc06
group metadata name assignment to directly access state.accountTree.w…
fabiobozzo Sep 19, 2025
5bc89b3
fix: implement per-wallet sequential account naming
fabiobozzo Sep 19, 2025
895007a
tiny changelog edit
fabiobozzo Sep 19, 2025
7d0c219
replace nullish coalescing assignment with direct assignment for acco…
fabiobozzo Sep 19, 2025
d243c52
Update packages/account-tree-controller/CHANGELOG.md
fabiobozzo Sep 19, 2025
38e0b5a
update tests to reflect new naming logic and ensure accuracy in accou…
fabiobozzo Sep 19, 2025
a6ec434
ignore testing init accountGroupsMetadata for groupId if it doesn't e…
fabiobozzo Sep 19, 2025
ffe2350
prettify
fabiobozzo Sep 19, 2025
3cc47b4
Merge branch 'main' into fix/account-group-names-consistency
fabiobozzo Sep 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions packages/account-tree-controller/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add `autoHandleConflict` parameter to `setAccountGroupName` method for automatic conflict resolution with suffix generation ([#6601](https://github.com/MetaMask/core/pull/6601))

### Changed

- Computed names (inherited from previous existing accounts) is disabled temporarily ([#6601](https://github.com/MetaMask/core/pull/6601))
- They do interfere with the naming mechanism, so we disable them temporarily in favor of the new per-wallet sequential naming.

### Fixed

- Fix multi-wallet account group naming inconsistencies and duplicates ([#6601](https://github.com/MetaMask/core/pull/6601))
- Implement proper per-wallet sequential numbering with highest account index parsing.
- Add name persistence during group initialization to ensure consistency across app restarts.

## [0.17.0]

### Changed
Expand Down Expand Up @@ -38,10 +53,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Bump `@metamask/utils` from `^11.4.2` to `^11.8.0` ([#6588](https://github.com/MetaMask/core/pull/6588))
- Bump `@metamask/base-controller` from `^8.3.0` to `^8.4.0` ([#6632](https://github.com/MetaMask/core/pull/6632))

### Removed

- Remove use of `:getSelectedAccount` action ([#6608](https://github.com/MetaMask/core/pull/6608))

## [0.15.1]

### Fixed
Expand Down
Loading
Loading