feat(account-tree-controller): do not enqueue single syncs during full syncs #6651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuartu
force-pushed
the
fix/no-atomic-syncs-if-full-sync-in-progress
branch
from
2253b70 to
33f10ab
Compare
mathieuartu
changed the title
mathieuartu
force-pushed
the
fix/no-atomic-syncs-if-full-sync-in-progress
branch
from
33f10ab to
af4c819
Compare
gantunesr
previously approved these changes
Sep 18, 2025
mathieuartu
force-pushed
the
fix/no-atomic-syncs-if-full-sync-in-progress
branch
from
3e573ce to
03dd30d
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mathieuartu
force-pushed
the
fix/no-atomic-syncs-if-full-sync-in-progress
branch
from
0bc6c4f to
ffc4c7c
Compare
ccharly
reviewed
Sep 18, 2025
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
ccharly
approved these changes
Sep 18, 2025
mathieuartu
deleted the
fix/no-atomic-syncs-if-full-sync-in-progress
branch
aganglada
pushed a commit
that referenced
this pull request
Sep 24, 2025
…l syncs (#6651) ## Explanation This PR prevents single sync events from being enqueued if a full sync is already in progress. This prevents unnecessary client side network calls. ## References Fixes: https://consensyssoftware.atlassian.net/browse/MUL-901 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR prevents single sync events from being enqueued if a full sync is already in progress.
This prevents unnecessary client side network calls.
References
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-901
Checklist