fix: fix added popular network #6693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
What is the current state of things and why does it need to change?
The current
#onAddNetworkbehavior inNetworkEnablementControllerwas inconsistent and didn't provide a good user experience:What is the solution your changes offer and how does it work?
This PR implements a more intuitive network addition behavior:
Improved Popular Networks Detection: Changed from requiring "all popular networks enabled" to ">2 popular networks enabled", making the detection much more practical and user-friendly.
Context-Aware Network Addition:
Key Benefits:
Are there any changes whose purpose might not obvious to those unfamiliar with the domain?
#areAllPopularNetworksEnabled()to#isInPopularNetworksMode()reflects the conceptual shift from checking all networks to checking if the user is in a "popular networks" usage patternReferences
This change improves the user experience for network management in MetaMask by implementing more intuitive network addition behavior based on user context.
Checklist