fix(account-tree-controller): fix duplicate names for out-of-order accounts #6706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We were not re-using the persisted group name when checking for the next available name during group metadata updates.
Meaning that if somehow, we were receiving a
:accountAdded
beforeinit
was called, then the groups metadata would be empty, leading to some duplicate names.I spotted this issue with mobile E2E and our fixture system.
References
E2E were failing on this PR, because of this bug:
Checklist