Skip to content

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Sep 24, 2025

Explanation

We were not re-using the persisted group name when checking for the next available name during group metadata updates.

Meaning that if somehow, we were receiving a :accountAdded before init was called, then the groups metadata would be empty, leading to some duplicate names.

I spotted this issue with mobile E2E and our fixture system.

References

E2E were failing on this PR, because of this bug:

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly ccharly marked this pull request as ready for review September 24, 2025 12:05
@ccharly ccharly requested review from a team as code owners September 24, 2025 12:05
@ccharly ccharly enabled auto-merge (squash) September 24, 2025 14:31
@ccharly ccharly merged commit 3de25ba into main Sep 24, 2025
239 checks passed
@ccharly ccharly deleted the fix/account-tree-controller-duplicate-names branch September 24, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants