feat(account-tree-controller): force-init before any account insertion/removal #6709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We now enforce that
init
got called before making any change to the tree to avoid having out-of-order account groups.I stumbled upon this bug when running E2E on mobile. Basically, the way the fixture are setup on mobile were triggering
:accountAdded
before callingAccountTreeController.init
, which resulted in having "Account 2" inserted before "Account 1".But, since "Account 1" was already part of the initial
internalAccounts
it should have been inserted before any new accounts.Thus, forcing
init
to be called implicitly fixes this order/sequence.References
E2E were failing on this PR, because of this bug:
Checklist