Skip to content

fix: read selectedAccount from quote request and submitTx args #6719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 25, 2025
+323 −156
Merged

fix: read selectedAccount from quote request and submitTx args #6719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1a6d7cf
fix: require accountAddress as submitTx param
micaelae Sep 24, 2025
5ea4b0a
fix: use quoteRequest address and getAccountByAddress in bridge-contr…
micaelae Sep 25, 2025
47e2bca
chore: update changelog
micaelae Sep 25, 2025
91ca6e1
chore: deprecate SnapConfirmationViewed event
micaelae Sep 25, 2025
54da068
chore: use is_hardware_wallet property from client if provided
micaelae Sep 25, 2025
cc1643d
test: bridge-controller unit tests
micaelae Sep 25, 2025
907faf5
fix: bridge-status-controller tests
micaelae Sep 25, 2025
6c16a44
Merge branch 'main' into mul983-get-account-by-address
micaelae Sep 25, 2025
9c04f10
chore: silence expected test warn logs
micaelae Sep 25, 2025
b9e43d2
refactor: only get account if adding nonEvm fees
micaelae Sep 25, 2025
93172fb
chore: update error message
micaelae Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/bridge-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- **BREAKING** Make `walletAddress` a required quote request parameter when calling the `updateBridgeQuoteRequestParams` handler ([#6719](https://github.com/MetaMask/core/pull/6719))
- Bump `@metamask/utils` from `^11.8.0` to `^11.8.1` ([#6708](https://github.com/MetaMask/core/pull/6708))

### Removed

- Deprecate the unused `SnapConfirmationViewed` event ([#6719](https://github.com/MetaMask/core/pull/6719))

### Fixed

- Replace `AccountsController:getSelectedMultichainAccount` usages with AccountsController:getAccountByAddress` when retrieving Solana account details for quote metadata ([#6719](https://github.com/MetaMask/core/pull/6719))

## [46.0.0]

### Added
Expand Down
42 changes: 16 additions & 26 deletions packages/bridge-controller/src/__snapshots__/bridge-controller.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,32 +164,6 @@ Array [
]
`;

exports[`BridgeController trackUnifiedSwapBridgeEvent bridge-status-controller calls should track the SnapConfirmationViewed event 1`] = `
Array [
Array [
"Unified SwapBridge Snap Confirmation Page Viewed",
Object {
"action_type": "swapbridge-v1",
"chain_id_destination": null,
"chain_id_source": "eip155:1",
"custom_slippage": false,
"gas_included": false,
"gas_included_7702": false,
"is_hardware_wallet": false,
"price_impact": 0,
"provider": "provider_bridge",
"quoted_time_minutes": 0,
"slippage_limit": undefined,
"swap_type": "crosschain",
"token_address_destination": null,
"token_address_source": "eip155:1/slip44:60",
"usd_quoted_gas": 0,
"usd_quoted_return": 0,
},
],
]
`;

exports[`BridgeController trackUnifiedSwapBridgeEvent bridge-status-controller calls should track the StatusValidationFailed event 1`] = `
Array [
Array [
Expand Down Expand Up @@ -393,6 +367,22 @@ Array [
`;

exports[`BridgeController trackUnifiedSwapBridgeEvent client-side calls should track the QuotesReceived event 1`] = `
Array [
Array [
"NetworkController:getState",
],
Array [
"NetworkController:getNetworkClientById",
"selectedNetworkClientId",
],
Array [
"AccountsController:getAccountByAddress",
"0x123",
],
]
`;

exports[`BridgeController trackUnifiedSwapBridgeEvent client-side calls should track the QuotesReceived event 2`] = `
Array [
Array [
"Unified SwapBridge Quotes Received",
Expand Down
Loading
Loading