feat: support EIP-5792 methods #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

matthewwalsh0 merged 11 commits into main from feat/eip-5792

Feb 14, 2025

Member

matthewwalsh0 commented Feb 11, 2025 •

edited

Loading

Support the EIP-5792 methods:

wallet_sendCalls
wallet_getCallsStatus
wallet_getCapabilities

Specifically:

Modularise new method support into separate files under src/methods.
- As opposed to continually extending src/wallet.ts.
Use @metamask/superstruct to easily validate request parameters against a schema / struct.
Move common validation functions to new src/validation.ts.
Export new types inferred from structs.
- Specifically as opposed to * for easier API diffs.

An additional benefit of using @metamask/superstruct is including multiple validation errors within a single RPC error:

Error: Invalid params

0 > from - Expected a string matching \`/^0x[0-9a-fA-F]{40}$/\` but received "123"
0 > chainId - Expected a string, but received: 123
0 > calls - Expected an array value, but received: "123"

matthewwalsh0 added 8 commits

February 9, 2025 23:46


          Add wallet_sendCalls

b0aaf31

Validate using superstruct.


          Add wallet_getCallsStatus

f3be963


          Add validation unit tests

fec5a17


          Add get calls status unit tests

f8010ec


          Add wallet_getCapabilities

7e705dc


          Export types

9e77943

Add unit tests.


          Fix unit tests

7f607ad


          Allow capabilities

b8f410d

matthewwalsh0 marked this pull request as ready for review

February 11, 2025 14:15

matthewwalsh0 requested a review from a team as a code owner

February 11, 2025 14:15

matthewwalsh0 added the team-confirmations label

jiexi reviewed

View reviewed changes

src/methods/wallet-get-calls-status.ts Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-get-calls-status.ts Outdated Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-get-calls-status.ts Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-get-calls-status.test.ts Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-get-calls-status.test.ts Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-get-capabilities.ts Outdated Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-get-capabilities.ts Outdated Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-send-calls.ts Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-send-calls.ts Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-send-calls.ts Outdated Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-send-calls.ts Outdated Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-send-calls.test.ts Outdated Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/methods/wallet-send-calls.test.ts Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/utils/validation.ts Show resolved Hide resolved

jiexi reviewed

View reviewed changes

src/utils/validation.ts Outdated Show resolved Hide resolved

matthewwalsh0 added 2 commits

February 11, 2025 21:57


          Require version

64c48e2

Add unit test.
Update types.


          Update capabilities result type

0077d6e

matthewwalsh0 requested a review from jiexi

February 11, 2025 22:38

OGPoyraz approved these changes

View reviewed changes

jiexi approved these changes

View reviewed changes

cryptodev-2s approved these changes

View reviewed changes

Contributor

cryptodev-2s left a comment

LGTM, I left a tiny typo fix comment

src/utils/validation.test.ts Show resolved Hide resolved


          Merge branch 'main' into feat/eip-5792

33d241b

matthewwalsh0 merged commit f212564 into main

20 checks passed

matthewwalsh0 deleted the feat/eip-5792 branch

February 14, 2025 12:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-confirmations